From: james.morse@arm•com (James Morse)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] arm64: allow building with kcov coverage on ARM64
Date: Thu, 16 Jun 2016 11:47:21 +0100 [thread overview]
Message-ID: <576283B9.9050900@arm.com> (raw)
In-Reply-To: <20160615142550.GA7971@leverpostej>
On 15/06/16 15:25, Mark Rutland wrote:
> On Wed, Jun 15, 2016 at 01:53:03PM +0200, Alexander Potapenko wrote:
>> On Wed, Jun 15, 2016 at 1:44 PM, Mark Rutland <mark.rutland@arm•com> wrote:
>>> On Wed, Jun 15, 2016 at 10:25:10AM +0100, Mark Rutland wrote:
>>>> On Tue, Jun 14, 2016 at 08:16:08PM +0200, Alexander Potapenko wrote:
>>>>> On Tue, Jun 14, 2016 at 7:55 PM, Mark Rutland <mark.rutland@arm•com> wrote:
>>>>>> I built and booted (via EFI) a kernel with this feature enabled (also
>>>>>> with the boot/Makefile change removed). I haven't tested the feature
>>>>>> itself as such, as I'm not sure how to do that.
>>>>> You can test it by running the test program from Documentation/kcov.txt.
>>>>
>>>> Ah, I hadn't spotted that. If I get the chance I'll try to give that a
>>>> go.
>>>
>>> I just had a go (with this applied atop of v4.7-rc3), and I get:
>>>
>>> root at ribbensteg:/home/nanook# ./kcov
>>> mmap: No such device
>>>
>>> The device exists (it was able to open the fd, evidently):
>>>
>>> root at ribbensteg:/home/nanook# ls -al /sys/kernel/debug/kcov
>>> -rw------- 1 root root 0 Jan 1 1970 /sys/kernel/debug/kcov
>>>
>>> Strace show me:
>>>
>>> openat(AT_FDCWD, "/sys/kernel/debug/kcov", O_RDWR) = 3
>>> ioctl(3, CHIOMOVE or CM_IOCGATR, 0x10000) = 0
>>> mmap(NULL, 524288, PROT_READ|PROT_WRITE, MAP_SHARED, 3, 0) = -1 ENODEV (No such device)
>>>
>>> It doesn't look like the error paths in kcov_mmap are hitting.
>>>
>>> Any ideas?
>> According to Dmitry (thanks, Dmitry!) this has regressed recently, but
>> there's a pending patch that should probably fix the problem:
>> http://lkml.iu.edu/hypermail/linux/kernel/1605.2/04379.html
>
> Thanks for the pointer! With that applied, the program runs.
>
> However, it looks like I missed a warning from the kernel build system,
> and my toolchain doesn't actually support -fsanitize-coverage=trace-pc,
> so I'm not going to be able to test that further.
I dusted off a compiler that supports this, and ran the sample program under
Documentation with the above unproxify patch.
Tested-by: James Morse <james.morse@arm•com>
Thanks,
James
next prev parent reply other threads:[~2016-06-16 10:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 16:57 [PATCH v2] arm64: allow building with kcov coverage on ARM64 Alexander Potapenko
2016-06-14 17:16 ` Alexander Potapenko
2016-06-14 17:55 ` Mark Rutland
2016-06-14 18:16 ` Alexander Potapenko
2016-06-15 9:25 ` Mark Rutland
2016-06-15 11:44 ` Mark Rutland
2016-06-15 11:53 ` Alexander Potapenko
2016-06-15 14:25 ` Mark Rutland
2016-06-15 14:36 ` Dmitry Vyukov
2016-06-15 15:05 ` Mark Rutland
2016-06-15 15:16 ` Dmitry Vyukov
2016-06-16 10:47 ` James Morse [this message]
2016-06-16 15:20 ` Alexander Potapenko
2016-06-16 15:44 ` Mark Rutland
2016-06-16 16:25 ` Catalin Marinas
2016-06-16 16:32 ` Mark Rutland
2016-06-16 16:36 ` Alexander Potapenko
2016-06-16 16:36 ` James Morse
2016-06-16 16:39 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576283B9.9050900@arm.com \
--to=james.morse@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox