From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH -next] PM / devfreq: event: Fix return value check in exynos_nocp_parse_dt()
Date: Mon, 20 Jun 2016 09:54:02 +0900 [thread overview]
Message-ID: <57673EAA.2020506@samsung.com> (raw)
In-Reply-To: <1466187003-19823-1-git-send-email-weiyj_lk@163.com>
Hi Wei,
On 2016? 06? 18? 03:10, weiyj_lk at 163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
>
> In case of error, the function platform_get_resource() returns NULL
> pointer not ERR_PTR(). Remove unneeded error handling on the result
> of a call to platform_get_resource() since the value is passed to
> devm_ioremap_resource().
This same patch was already merged to devfreq git[1].
[1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=fixes&id=482c27865b9784831dad45b31c2b0a5c42376802
Thanks,
Chanwoo Choi
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
> ---
> drivers/devfreq/event/exynos-nocp.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
> index 6b6a5f3..a584140 100644
> --- a/drivers/devfreq/event/exynos-nocp.c
> +++ b/drivers/devfreq/event/exynos-nocp.c
> @@ -220,9 +220,6 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev,
>
> /* Maps the memory mapped IO to control nocp register */
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (IS_ERR(res))
> - return PTR_ERR(res);
> -
> base = devm_ioremap_resource(dev, res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
prev parent reply other threads:[~2016-06-20 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160617181052epcas1p34d888fccc7f58186cd2b0e2b1fed3e39@epcas1p3.samsung.com>
2016-06-17 18:10 ` [PATCH -next] PM / devfreq: event: Fix return value check in exynos_nocp_parse_dt() weiyj_lk at 163.com
2016-06-20 0:54 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57673EAA.2020506@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox