From: wangkefeng.wang@huawei•com (Kefeng Wang)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH] clocksource: arm_arch_timer: disable the evtstrm via the cmdline
Date: Mon, 20 Jun 2016 09:28:10 +0800 [thread overview]
Message-ID: <576746AA.70208@huawei.com> (raw)
In-Reply-To: <20160617143610.GA32087@leverpostej>
On 2016/6/17 22:36, Mark Rutland wrote:
> On Fri, Jun 17, 2016 at 02:43:31PM +0100, Will Deacon wrote:
>> Disabling the eventstream can be useful for debugging and development
>> purposes and is currently controlled via a Kconfig option
>> (CONFIG_ARM_ARCH_TIMER_EVTSTREAM). Whilst this does the trick, it's
>> often desirable to toggle the feature on the command line, so this patch
>> adds a "noevtstrm" command line option to do just that.
>
> I think anything that allows for better debugging on a production
> kernels is great, so FWIW:
Agree, I run linux in arm esl and the linux can't boot up without
ARM_ARCH_TIMER_EVTSTREAM recently.
The esl guys is looking into the issue, and it is useful to debug issue
with one Image(dynamic switching in cmdline).
BRs,
Kefeng
>
> Acked-by: Mark Rutland <mark.rutland@arm•com>
>
> We might want to drop something in Documentation/kernel-parameters.txt
>
> Mark.
>
>>
>> Signed-off-by: Will Deacon <will.deacon@arm•com>
>> ---
>>
>> Sending as an RFC because we might want to remove the Kconfig option
>> altogether if we have this.
>>
>> drivers/clocksource/arm_arch_timer.c | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
>> index 4814446a0024..f579c0da7423 100644
>> --- a/drivers/clocksource/arm_arch_timer.c
>> +++ b/drivers/clocksource/arm_arch_timer.c
>> @@ -79,6 +79,15 @@ static enum ppi_nr arch_timer_uses_ppi = VIRT_PPI;
>> static bool arch_timer_c3stop;
>> static bool arch_timer_mem_use_virtual;
>>
>> +static bool evtstrm_disable;
>> +
>> +static int __init early_evtstrm_disable(char *buf)
>> +{
>> + evtstrm_disable = true;
>> + return 0;
>> +}
>> +early_param("noevtstrm", early_evtstrm_disable);
>> +
>> /*
>> * Architected system timer support.
>> */
>> @@ -372,7 +381,7 @@ static int arch_timer_setup(struct clock_event_device *clk)
>> enable_percpu_irq(arch_timer_ppi[PHYS_NONSECURE_PPI], 0);
>>
>> arch_counter_set_user_access();
>> - if (IS_ENABLED(CONFIG_ARM_ARCH_TIMER_EVTSTREAM))
>> + if (IS_ENABLED(CONFIG_ARM_ARCH_TIMER_EVTSTREAM) && !evtstrm_disable)
>> arch_timer_configure_evtstream();
>>
>> return 0;
>> --
>> 2.1.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> .
>
next prev parent reply other threads:[~2016-06-20 1:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 13:43 [RFC PATCH] clocksource: arm_arch_timer: disable the evtstrm via the cmdline Will Deacon
2016-06-17 14:36 ` Mark Rutland
2016-06-20 1:28 ` Kefeng Wang [this message]
2016-06-19 20:08 ` Daniel Lezcano
2016-06-20 8:21 ` Will Deacon
2016-06-20 8:34 ` Marc Zyngier
2016-06-20 12:59 ` Daniel Lezcano
2016-06-20 13:27 ` Mark Rutland
2016-06-20 13:30 ` Will Deacon
2016-06-20 13:44 ` Mark Rutland
2016-06-20 13:30 ` Catalin Marinas
2016-06-27 14:44 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576746AA.70208@huawei.com \
--to=wangkefeng.wang@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox