From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 2/4] power: reset: add reboot mode driver
Date: Tue, 21 Jun 2016 13:39:45 +0200 [thread overview]
Message-ID: <57692781.4070506@samsung.com> (raw)
In-Reply-To: <57691E92.5090205@rock-chips.com>
On 06/21/2016 01:01 PM, Andy Yan wrote:
(...)
>>> +MODULE_AUTHOR("Andy Yan <andy.yan@rock-chips•com");
>>> +MODULE_DESCRIPTION("System reboot mode driver");
>>> +MODULE_LICENSE("GPL v2");
>>> diff --git a/drivers/power/reset/reboot-mode.h
>>> b/drivers/power/reset/reboot-mode.h
>>> new file mode 100644
>>> index 0000000..44ed34f
>>> --- /dev/null
>>> +++ b/drivers/power/reset/reboot-mode.h
>>> @@ -0,0 +1,6 @@
>>> +#ifndef __REBOOT_MODE_H__
>>> +#define __REBOOT_MODE_H__
>>> +
>>> +int reboot_mode_register(struct device *dev, int (*write)(int));
>> Documentation would be appreciated. Although it is local header but
>> you decoupled them and you are exporting the function.
>
> You want this driver being a module in V9, so you may also want
> I document this function when a exporting it. Where I should write the
> documentation, and would you please give me some example?
Follow kernel-doc (kernel-doc-nano-HOWTO.txt). There is an example. Put
the documentation of functions next to them in source file (not header).
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-06-21 11:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 11:35 [PATCH v6 0/4] add reboot mode driver Andy Yan
2016-03-22 11:36 ` [PATCH v6 1/4] dt-bindings: power: reset: add document for reboot-mode driver Andy Yan
2016-03-24 2:27 ` Krzysztof Kozlowski
2016-03-24 7:27 ` Andy Yan
2016-03-24 7:47 ` Krzysztof Kozlowski
2016-03-22 11:37 ` [PATCH v6 2/4] power: reset: add reboot mode driver Andy Yan
2016-03-24 2:50 ` Krzysztof Kozlowski
2016-03-24 8:03 ` Andy Yan
2016-03-28 6:34 ` Krzysztof Kozlowski
2016-03-28 7:40 ` Andy Yan
2016-03-28 8:05 ` Krzysztof Kozlowski
2016-06-21 11:01 ` Andy Yan
2016-06-21 11:39 ` Krzysztof Kozlowski [this message]
2016-03-22 11:38 ` [PATCH v6 3/4] ARM: dts: rockchip: add syscon-reboot-mode DT node Andy Yan
2016-03-22 11:38 ` [PATCH v6 4/4] ARM64: " Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57692781.4070506@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox