From: jonathanh@nvidia•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 6/8] PM / Domains: Remove a provider by referencing the data pointer
Date: Tue, 21 Jun 2016 15:45:09 +0100 [thread overview]
Message-ID: <576952F5.5020808@nvidia.com> (raw)
In-Reply-To: <1457090634-14785-7-git-send-email-jonathanh@nvidia.com>
On 04/03/16 11:23, Jon Hunter wrote:
> To remove a PM domain from the system, it is necessary to ensure
> that any PM domain providers associated with the PM domain have
> been removed. Otherwise it could be possible to obtain a pointer
> to a PM domain structure that has been removed.
>
> PM domains now have a reference to the pointer for the PM domain
> provider's data variable. Add a function so that a PM domain can
> remove a PM domain provider by referencing the data pointer.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia•com>
> ---
> drivers/base/power/domain.c | 24 ++++++++++++++++++++++++
> include/linux/pm_domain.h | 2 ++
> 2 files changed, 26 insertions(+)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 72055fef6256..438885f2455f 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1738,6 +1738,30 @@ void of_genpd_del_provider(struct device_node *np)
> EXPORT_SYMBOL_GPL(of_genpd_del_provider);
>
> /**
> + * of_genpd_del_provider_by_data() - Remove a registered PM domain provider
> + * @data: Pointer to the data associated with the PM domain provider
> + *
> + * Look up a PM domain provider based upon a pointer to it's data and
> + * remove the PM domain provider from the list of providers.
> + */
> +void of_genpd_del_provider_by_data(void *data)
> +{
> + struct of_genpd_provider *c, *cp;
> +
> + mutex_lock(&of_genpd_mutex);
> + list_for_each_entry_safe(cp, c, &of_genpd_providers, link) {
> + if (cp->data == data) {
> + list_del(&cp->link);
> + of_node_put(cp->node);
> + kfree(cp);
> + break;
> + }
> + }
> + mutex_unlock(&of_genpd_mutex);
On further the thought I believe that the above does not need to be safe
variant of list_for_each_entry because we are breaking out of the loop
when we find the one we are looking for. of_genpd_del_provider() does
the same.
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-06-21 14:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 11:23 [RFC PATCH 0/8] PM / Domains: Add support for removing PM domains Jon Hunter
2016-03-04 11:23 ` [RFC PATCH 1/8] PM / Domains: Add new helper functions for device-tree Jon Hunter
2016-06-22 11:00 ` Jon Hunter
2016-06-22 14:58 ` Jon Hunter
2016-06-22 15:08 ` Ulf Hansson
2016-06-22 15:22 ` Jon Hunter
2016-06-22 15:36 ` Ulf Hansson
2016-03-04 11:23 ` [RFC PATCH 2/8] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider() Jon Hunter
2016-03-04 11:23 ` [RFC PATCH 3/8] staging: board: " Jon Hunter
2016-03-04 11:23 ` [RFC PATCH 4/8] PM / Domains: Don't expose generic_pm_domain structure Jon Hunter
2016-08-05 11:55 ` Ulf Hansson
2016-03-04 11:23 ` [RFC PATCH 5/8] PM / Domains: Verify the PM domain is present when adding a provider Jon Hunter
2016-08-05 11:57 ` Ulf Hansson
2016-03-04 11:23 ` [RFC PATCH 6/8] PM / Domains: Remove a provider by referencing the data pointer Jon Hunter
2016-06-15 14:38 ` Ulf Hansson
2016-06-21 13:47 ` Jon Hunter
2016-07-11 13:14 ` Jon Hunter
2016-08-05 11:55 ` Ulf Hansson
2016-08-11 16:39 ` Jon Hunter
2016-08-12 0:24 ` Rafael J. Wysocki
2016-06-21 14:45 ` Jon Hunter [this message]
2016-03-04 11:23 ` [RFC PATCH 7/8] PM / Domains: Prepare for adding support to remove PM domains Jon Hunter
2016-03-04 11:23 ` [RFC PATCH 8/8] PM / Domains: Add support for removing " Jon Hunter
2016-06-15 14:33 ` Ulf Hansson
2016-06-21 14:08 ` Jon Hunter
2016-03-04 12:33 ` [RFC PATCH 0/8] " Ulf Hansson
2016-03-28 12:38 ` Jon Hunter
2016-06-06 13:19 ` Jon Hunter
2016-06-15 14:46 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576952F5.5020808@nvidia.com \
--to=jonathanh@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox