From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clocksource: timer-atmel-pit: enable mck
Date: Tue, 5 Jul 2016 09:47:43 +0200 [thread overview]
Message-ID: <577B661F.5090703@atmel.com> (raw)
In-Reply-To: <20160704222404.5132c3d3@bbrezillon>
Le 04/07/2016 22:24, Boris Brezillon a ?crit :
> On Mon, 4 Jul 2016 18:00:09 +0200
> Alexandre Belloni <alexandre.belloni@free-electrons•com> wrote:
>
>> mck is needed to get the PIT working. Explicitly prepare_enable it instead
>> of assuming it is enabled.
>>
>> This solves an issue were the system is freezing when the ETM/ETB drivers
>
> ^ where
>
>> are enabled.
>>
>> Reported-by: Olivier Schonken <olivier.schonken@gmail•com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons•com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons•com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
>> ---
>> drivers/clocksource/timer-atmel-pit.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
>> index d911c5dca8f1..fcc97711cd79 100644
>> --- a/drivers/clocksource/timer-atmel-pit.c
>> +++ b/drivers/clocksource/timer-atmel-pit.c
>> @@ -248,6 +248,9 @@ static void __init at91sam926x_pit_dt_init(struct device_node *node)
>> if (IS_ERR(data->mck))
>> panic(pr_fmt("Unable to get mck clk\n"));
>>
>> + if (clk_prepare_enable(data->mck))
>> + panic(pr_fmt("Unable to enable mck\n"));
>> +
>> /* Get the interrupts property */
>> data->irq = irq_of_parse_and_map(node, 0);
>> if (!data->irq)
>
>
--
Nicolas Ferre
prev parent reply other threads:[~2016-07-05 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 16:00 [PATCH] clocksource: timer-atmel-pit: enable mck Alexandre Belloni
2016-07-04 20:24 ` Boris Brezillon
2016-07-05 7:47 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577B661F.5090703@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox