From: k.kozlowski@samsung•com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH -next v2] iommu/exynos: Fix return value check in exynos_iommu_of_setup()
Date: Thu, 07 Jul 2016 11:43:30 +0200 [thread overview]
Message-ID: <577E2442.4000002@samsung.com> (raw)
In-Reply-To: <1467860372-6940-1-git-send-email-weiyj_lk@163.com>
On 07/07/2016 04:59 AM, weiyj_lk at 163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
>
> In case of error, the function of_platform_device_create() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value
> check should be replaced with NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro•com.cn>
> ---
> v1 -> v2: chenge the error code to -ENODEV
> ---
> drivers/iommu/exynos-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Why you didn't include mine and Dennis reviews? Why you ignored my
comments - you don't agree with them?
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-07-07 9:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:15 [PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup() weiyj_lk at 163.com
2016-07-06 12:47 ` Dennis Chen
2016-07-06 13:09 ` Krzysztof Kozlowski
2016-07-07 2:34 ` Andi Shyti
2016-07-07 2:50 ` Wei Yongjun
2016-07-18 7:34 ` Marek Szyprowski
2016-07-07 2:59 ` [PATCH -next v2] " weiyj_lk at 163.com
2016-07-07 4:25 ` Andi Shyti
2016-07-07 9:43 ` Krzysztof Kozlowski [this message]
2016-07-07 12:09 ` Wei Yongjun
2016-07-07 12:17 ` [PATCH -next v3] " weiyj_lk at 163.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E2442.4000002@samsung.com \
--to=k.kozlowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox