From: ldewangan@nvidia•com (Laxman Dewangan)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] mfd: Provide MACRO to declare commonly defined MFD cell attributes
Date: Fri, 15 Jul 2016 18:39:39 +0530 [thread overview]
Message-ID: <5788E093.7080405@nvidia.com> (raw)
In-Reply-To: <20160713112651.14539-2-lee.jones@linaro.org>
On Wednesday 13 July 2016 04:56 PM, Lee Jones wrote:
> Cc: Laxman Dewangan <ldewangan@nvidia•com>
> Signed-off-by: Lee Jones <lee.jones@linaro•org>
> ---
> include/linux/mfd/core.h | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
> index 99c0395..c6018f4 100644
> --- a/include/linux/mfd/core.h
> +++ b/include/linux/mfd/core.h
> @@ -16,6 +16,35 @@
>
> #include <linux/platform_device.h>
> +#define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id) \
> + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL) \
> +
> +#define MFD_CELL_RES(_name, _res) \
> + MFD_CELL_ALL(_name, _res, _pdata, 0, 0, NULL, NULL) \
> +
Here _pdata should not be used. Instead it should be NULL.
I corrected it locally and then compiled and teste.
Once above fixed, you can take my ack and tested by
Acked-by: Laxman Dewangan <ldewangan@nvidia•com>
Tested-by: Laxman Dewangan <ldewangan@nvidia•com>
next prev parent reply other threads:[~2016-07-15 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 11:26 [PATCH 0/3] mfd: Provide MACRO to declare commonly defined MFD cell attributes Lee Jones
2016-07-13 11:26 ` [PATCH 1/3] " Lee Jones
2016-07-15 13:09 ` Laxman Dewangan [this message]
2016-07-18 13:25 ` Lee Jones
2016-07-13 11:26 ` [PATCH 2/3] mfd: ab8500: Example using new OF_MFD_CELL MACRO Lee Jones
2016-07-13 11:26 ` [PATCH 3/3] mfd: db8500-prcmu: Example using new OF_MFD_CELL/MFD_CELL_BASIC MACROs Lee Jones
2016-08-04 7:47 ` Linus Walleij
2016-08-05 7:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5788E093.7080405@nvidia.com \
--to=ldewangan@nvidia$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox