From: slash.tmp@free•fr (Mason)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] thermal: tango: add resume support
Date: Mon, 18 Jul 2016 14:21:29 +0200 [thread overview]
Message-ID: <578CC9C9.3050806@free.fr> (raw)
In-Reply-To: <57726196.5060909@free.fr>
From: Marc Gonzalez <marc_gonzalez@sigmadesigns•com>
When this platform is suspended, firmware powers the entire SoC down,
except a few hardware blocks waiting for wakeup events. And there is
no context to save for this particular block.
Therefore, there is nothing useful for the driver to do on suspend;
so we define a NULL suspend hook. On resume, the driver initializes
the block exactly as is done in the probe callback.
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns•com>
---
Changes in v3
Drop the DEV_PM_OPS macro, which caused some confusion.
Note: tango_thermal_pm struct only exists when CONFIG_PM_SLEEP is defined
@Kevin, can I add your Reviewed-by tag back?
---
drivers/thermal/tango_thermal.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
index 70e0d9f406e9..957f8937e126 100644
--- a/drivers/thermal/tango_thermal.c
+++ b/drivers/thermal/tango_thermal.c
@@ -64,6 +64,12 @@ static const struct thermal_zone_of_device_ops ops = {
.get_temp = tango_get_temp,
};
+static void tango_thermal_init(struct tango_thermal_priv *priv)
+{
+ writel(0, priv->base + TEMPSI_CFG);
+ writel(CMD_ON, priv->base + TEMPSI_CMD);
+}
+
static int tango_thermal_probe(struct platform_device *pdev)
{
struct resource *res;
@@ -79,14 +85,24 @@ static int tango_thermal_probe(struct platform_device *pdev)
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
+ platform_set_drvdata(pdev, priv);
priv->thresh_idx = IDX_MIN;
- writel(0, priv->base + TEMPSI_CFG);
- writel(CMD_ON, priv->base + TEMPSI_CMD);
+ tango_thermal_init(priv);
tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops);
return PTR_ERR_OR_ZERO(tzdev);
}
+#ifdef CONFIG_PM_SLEEP
+static int tango_thermal_resume(struct device *dev)
+{
+ tango_thermal_init(dev_get_drvdata(dev));
+ return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(tango_thermal_pm, NULL, tango_thermal_resume);
+#endif
+
static const struct of_device_id tango_sensor_ids[] = {
{
.compatible = "sigma,smp8758-thermal",
@@ -99,6 +115,9 @@ static struct platform_driver tango_thermal_driver = {
.driver = {
.name = "tango-thermal",
.of_match_table = tango_sensor_ids,
+#ifdef CONFIG_PM_SLEEP
+ .pm = &tango_thermal_pm,
+#endif
},
};
--
2.9.0
next prev parent reply other threads:[~2016-07-18 12:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 11:37 [RESEND PATCH v2] thermal: tango: add resume support Mason
2016-07-18 9:33 ` Thierry Reding
2016-07-18 10:09 ` Arnd Bergmann
2016-07-18 10:13 ` Thierry Reding
2016-07-18 11:10 ` Arnd Bergmann
2016-07-18 11:28 ` Thierry Reding
2016-07-18 12:21 ` Mason [this message]
2016-07-20 10:50 ` [PATCH v3] " Thierry Reding
2016-07-22 22:00 ` Kevin Hilman
2016-07-25 8:18 ` Mason
2016-07-25 8:52 ` Arnd Bergmann
2016-07-25 9:48 ` Mason
2016-07-26 12:13 ` Arnd Bergmann
2016-08-19 11:29 ` Zhang Rui
2016-08-22 21:00 ` Arnd Bergmann
2016-08-24 8:25 ` Zhang Rui
2016-08-24 8:32 ` Arnd Bergmann
2016-08-24 15:12 ` Mason
2016-09-02 13:17 ` [PATCH v4] " Marc Gonzalez
2016-09-02 20:54 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578CC9C9.3050806@free.fr \
--to=slash.tmp@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox