From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller
Date: Wed, 10 Aug 2016 13:29:14 +0900 [thread overview]
Message-ID: <57AAAD9A.1090201@samsung.com> (raw)
In-Reply-To: <1470799604-12877-5-git-send-email-hl@rock-chips.com>
Hi Lin,
On 2016? 08? 10? 12:26, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
>
> Signed-off-by: Lin Huang <hl@rock-chips•com>
> ---
> Changes in v5:
> -None
>
> Changes in v4:
> -None
>
> Changes in v3:
> -None
>
> Changes in v2:
> -None
>
> Changes in v1:
> -None
>
> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..bf42255
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,20 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> + dfi: dfi at 0xff630000 {
> + reg = <0x00 0xff630000 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
Usually, the compatible is first entry within Device-tree node.
> + rockchip,pmu = <&pmugrf>;
> + clocks = <&cru PCLK_DDR_MON>;
> + clock-names = "pclk_ddr_mon";
> + status = "disabled";
> + };
> +
>
Looks good to me. Just I want to change the sequence
between 'compatible' and 'reg' property.
Acked-by: Chanwoo Choi <cw00.choi@samsung•com>
Regards,
Chawnoo Choi
next prev parent reply other threads:[~2016-08-10 4:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 3:26 [PATCH v5 0/8] rk3399 support ddr frequency scaling Lin Huang
2016-08-10 3:26 ` [PATCH v5 1/8] clk: rockchip: add new clock-type for the ddrclk Lin Huang
2016-08-10 3:26 ` [PATCH v5 2/8] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc Lin Huang
2016-08-10 3:26 ` [PATCH v5 3/8] clk: rockchip: rk3399: add ddrc clock support Lin Huang
2016-08-10 3:26 ` [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller Lin Huang
2016-08-10 4:29 ` Chanwoo Choi [this message]
2016-08-10 3:26 ` [PATCH v5 5/8] PM / devfreq: event: support rockchip " Lin Huang
2016-08-10 3:26 ` [PATCH v5 6/8] Documentation: bindings: add dt documentation for rk3399 dmc Lin Huang
2016-08-10 4:38 ` Chanwoo Choi
2016-08-10 3:26 ` [PATCH v5 7/8] PM / devfreq: rockchip: add devfreq driver " Lin Huang
2016-08-10 4:39 ` [PATCH] PM / devfreq: rockchip: fix semicolon.cocci warnings kbuild test robot
2016-08-10 4:39 ` [PATCH v5 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc kbuild test robot
2016-08-10 5:01 ` Chanwoo Choi
2016-08-10 9:05 ` kbuild test robot
2016-08-10 9:07 ` kbuild test robot
2016-08-10 3:26 ` [PATCH v5 8/8] drm/rockchip: Add dmc notifier in vop driver Lin Huang
2016-08-10 5:07 ` Chanwoo Choi
2016-08-10 5:28 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AAAD9A.1090201@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox