From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 4/8] Documentation: bindings: add dt documentation for dfi controller
Date: Wed, 17 Aug 2016 09:41:26 +0900 [thread overview]
Message-ID: <57B3B2B6.3020201@samsung.com> (raw)
In-Reply-To: <57B3B06C.1040109@samsung.com>
Hi Lin,
I add the additional comment.
On 2016? 08? 17? 09:31, Chanwoo Choi wrote:
> Hi Lin,
>
> I add one minor comment.
>
> After fixing it, looks good to me.
> Acked-by: Chanwoo Choi <cw00.choi@samsung•com>
>
> On 2016? 08? 17? 07:36, Lin Huang wrote:
>> This patch adds the documentation for rockchip dfi devfreq-event driver.
>>
>> Signed-off-by: Lin Huang <hl@rock-chips•com>
>> ---
>> Changes in v6:
>> -None
>>
>> Changes in v5:
>> -None
>>
>> Changes in v4:
>> -None
>>
>> Changes in v3:
>> -None
>>
>> Changes in v2:
>> -None
>>
>> Changes in v1:
>> -None
>>
>> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>>
>> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>> new file mode 100644
>> index 0000000..bf42255
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>> @@ -0,0 +1,20 @@
>> +
>> +* Rockchip rk3399 DFI device
>> +
>> +Required properties:
>> +- compatible: Must be "rockchip,rk3399-dfi".
>> +- reg: physical base address of each DFI and length of memory mapped region
>> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
>> +- clocks: phandles for clock specified in "clock-names" property
>> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
>> +
>> +Example:
>> + dfi: dfi at 0xff630000 {
>> + reg = <0x00 0xff630000 0x00 0x4000>;
>> + compatible = "rockchip,rk3399-dfi";
As I said on previous mail-thread, the 'compatible' property
is first usually. You better to change the order as following:
compatible = "rockchip,rk3399-dfi";
reg = <0x00 0xff630000 0x00 0x4000>;
>> + rockchip,pmu = <&pmugrf>;
>> + clocks = <&cru PCLK_DDR_MON>;
>> + clock-names = "pclk_ddr_mon";
>> + status = "disabled";
>> + };
>> +
>
> Remove the blank line.
>
> Thanks,
> Chanwoo Choi
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2016-08-17 0:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 22:36 [PATCH v6 0/8] rk3399 support ddr frequency scaling Lin Huang
2016-08-16 22:36 ` [PATCH v6 1/8] clk: rockchip: add new clock-type for the ddrclk Lin Huang
2016-08-19 11:33 ` Heiko Stuebner
2016-08-16 22:36 ` [PATCH v6 2/8] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc Lin Huang
2016-08-16 22:36 ` [PATCH v6 3/8] clk: rockchip: rk3399: add ddrc clock support Lin Huang
2016-08-19 12:26 ` Heiko Stuebner
2016-08-16 22:36 ` [PATCH v6 4/8] Documentation: bindings: add dt documentation for dfi controller Lin Huang
2016-08-17 0:31 ` Chanwoo Choi
2016-08-17 0:41 ` Chanwoo Choi [this message]
2016-08-16 22:36 ` [PATCH v6 5/8] PM / devfreq: event: support rockchip " Lin Huang
2016-08-16 22:36 ` [PATCH v6 6/8] Documentation: bindings: add dt documentation for rk3399 dmc Lin Huang
2016-08-17 4:50 ` Chanwoo Choi
2016-08-21 22:16 ` hl
2016-08-23 5:05 ` Chanwoo Choi
2016-08-23 18:53 ` hl
2016-08-16 22:36 ` [PATCH v6 7/8] PM / devfreq: rockchip: add devfreq driver " Lin Huang
2016-08-17 0:37 ` Chanwoo Choi
2016-08-16 22:36 ` [PATCH v6 8/8] drm/rockchip: Add dmc notifier in vop driver Lin Huang
2016-08-17 18:14 ` Sean Paul
2016-08-17 18:51 ` hl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B3B2B6.3020201@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox