public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller
Date: Fri, 02 Sep 2016 17:50:54 +0900	[thread overview]
Message-ID: <57C93D6E.8090600@samsung.com> (raw)
In-Reply-To: <1472769085-20715-2-git-send-email-hl@rock-chips.com>

On 2016? 09? 02? 07:31, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
> 
> Signed-off-by: Lin Huang <hl@rock-chips•com>
> ---
> Changes in v8:
> - delete a unuse blank line
> 
> Changes in v7:
> - None
> 
> Changes in v6:
> - None
> 
> Changes in v5:
> - None
> 
> Changes in v4:
> - None
> 
> Changes in v3:
> - None
> 
> Changes in v2:
> - None 
> 
> Changes in v1:
> - None
> 
>  .../bindings/devfreq/event/rockchip-dfi.txt           | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..d66aca6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,19 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> +	dfi: dfi at 0xff630000 {
> +		reg = <0x00 0xff630000 0x00 0x4000>;
> +		compatible = "rockchip,rk3399-dfi";

As I already commented, you need to reorder between compatible and reg property.

> +		rockchip,pmu = <&pmugrf>;
> +		clocks = <&cru PCLK_DDR_MON>;
> +		clock-names = "pclk_ddr_mon";
> +		status = "disabled";
> +	};
> 


-- 
Best Regards,
Chanwoo Choi

  reply	other threads:[~2016-09-02  8:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 22:31 [PATCH 0/5] rk3399 support ddr frequency scaling Lin Huang
2016-09-01 22:31 ` [PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller Lin Huang
2016-09-02  8:50   ` Chanwoo Choi [this message]
2016-09-01 22:31 ` [PATCH 2/5] PM / devfreq: event: support rockchip " Lin Huang
2016-09-01 22:31 ` [PATCH 3/5] Documentation: bindings: add dt documentation for rk3399 dmc Lin Huang
2016-09-02  8:53   ` Chanwoo Choi
2016-09-01 22:31 ` [PATCH 4/5] PM / devfreq: rockchip: add devfreq driver " Lin Huang
2016-09-01 23:17   ` Heiko Stübner
2016-09-02  1:46     ` Chanwoo Choi
2016-09-02  1:23   ` kbuild test robot
2016-09-05  0:49     ` Chanwoo Choi
2016-09-01 22:31 ` [PATCH 5/5] drm/rockchip: Add dmc notifier in vop driver Lin Huang
2016-09-02  0:34   ` kbuild test robot
  -- strict thread matches above, loose matches on Subject: below --
2016-09-02 21:08 [PATCH 0/5] rk3399 support ddr frequency scaling Lin Huang
2016-09-02 21:08 ` [PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller Lin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57C93D6E.8090600@samsung.com \
    --to=cw00.choi@samsung$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox