From: alim.akhtar@samsung•com (Alim Akhtar)
To: linux-arm-kernel@lists•infradead.org
Subject: [1/4] ARM: EXYNOS: Remove smp_init_cpus hook from platsmp.c
Date: Fri, 04 Nov 2016 18:23:04 +0530 [thread overview]
Message-ID: <581C84B0.8000305@samsung.com> (raw)
In-Reply-To: <1478230764-13748-2-git-send-email-pankaj.dubey@samsung.com>
Hi Pankaj,
On 11/04/2016 09:09 AM, Pankaj Dubey wrote:
> We can safely remove exynos_smp_init_cpus() hook from mach-exynos/platsmp.c,
> as all SMP platforms in mach-exynos can rely on DT for CPU core description
> instead of determining number of cores from the SCU.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung•com>
> arch/arm/mach-exynos/platsmp.c | 31 -------------------------------
> 1 file changed, 31 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 98ffe1e..a5d6841 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -385,36 +385,6 @@ fail:
> return pen_release != -1 ? ret : 0;
> }
>
> -/*
> - * Initialise the CPU possible map early - this describes the CPUs
> - * which may be present or become present in the system.
> - */
> -
> -static void __init exynos_smp_init_cpus(void)
> -{
> - void __iomem *scu_base = scu_base_addr();
> - unsigned int i, ncores;
> -
> - if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
> - ncores = scu_base ? scu_get_core_count(scu_base) : 1;
> - else
> - /*
> - * CPU Nodes are passed thru DT and set_cpu_possible
> - * is set by "arm_dt_init_cpu_maps".
> - */
> - return;
> -
> - /* sanity check */
> - if (ncores > nr_cpu_ids) {
> - pr_warn("SMP: %u cores greater than maximum (%u), clipping\n",
> - ncores, nr_cpu_ids);
> - ncores = nr_cpu_ids;
> - }
> -
> - for (i = 0; i < ncores; i++)
> - set_cpu_possible(i, true);
> -}
> -
> static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
> {
> int i;
> @@ -479,7 +449,6 @@ static void exynos_cpu_die(unsigned int cpu)
> #endif /* CONFIG_HOTPLUG_CPU */
>
> const struct smp_operations exynos_smp_ops __initconst = {
> - .smp_init_cpus = exynos_smp_init_cpus,
> .smp_prepare_cpus = exynos_smp_prepare_cpus,
> .smp_secondary_init = exynos_secondary_init,
> .smp_boot_secondary = exynos_boot_secondary,
>
next prev parent reply other threads:[~2016-11-04 12:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161104033644epcas1p46d49c63576294d645c7fc131374bb49b@epcas1p4.samsung.com>
2016-11-04 3:39 ` [PATCH 0/4] Add SCU device node support for Exynos4 Pankaj Dubey
2016-11-04 3:39 ` [PATCH 1/4] ARM: EXYNOS: Remove smp_init_cpus hook from platsmp.c Pankaj Dubey
2016-11-04 12:53 ` Alim Akhtar [this message]
2016-11-05 15:41 ` Krzysztof Kozlowski
2016-11-07 3:37 ` pankaj.dubey
2016-11-07 6:59 ` Krzysztof Kozlowski
2016-11-07 17:10 ` Pankaj Dubey
2016-11-04 3:39 ` [PATCH 2/4] ARM: dts: exynos: Add SCU device node to exynos4.dtsi Pankaj Dubey
2016-11-04 13:13 ` [2/4] " Alim Akhtar
2016-11-05 15:41 ` [PATCH 2/4] " Krzysztof Kozlowski
2016-11-04 3:39 ` [PATCH 3/4] ARM: EXYNOS: Remove static mapping of SCU SFR Pankaj Dubey
2016-11-04 13:26 ` [3/4] " Alim Akhtar
2016-11-07 2:35 ` pankaj.dubey
2016-11-07 4:49 ` Alim Akhtar
2016-11-07 16:59 ` Pankaj Dubey
2016-11-07 17:53 ` [PATCH 3/4] " Krzysztof Kozlowski
2016-11-08 3:14 ` pankaj.dubey
2016-11-04 3:39 ` [PATCH 4/4] ARM: EXYNOS: Remove unused soc_is_exynos{4,5} Pankaj Dubey
2016-11-04 13:31 ` [4/4] " Alim Akhtar
2016-11-04 7:33 ` [PATCH 0/4] Add SCU device node support for Exynos4 Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=581C84B0.8000305@samsung.com \
--to=alim.akhtar@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox