From: vladimir.murzin@arm•com (Vladimir Murzin)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 04/11] PCI: tegra: limit to MMU build only
Date: Tue, 22 Nov 2016 09:40:39 +0000 [thread overview]
Message-ID: <58341297.9090303@arm.com> (raw)
In-Reply-To: <11637152.Dd0IBkEQ8q@wuerfel>
On 22/11/16 09:31, Arnd Bergmann wrote:
> On Tuesday, November 22, 2016 9:26:01 AM CET Vladimir Murzin wrote:
>> This driver uses functionality which available for MMU build only,
>> thus add dependency on MMU.
>>
>> Cc: Thierry Reding <thierry.reding@gmail•com>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm•com>
>>
>
> Can you be more specific about what requires the MMU here?
>
> Is it the I/O space remapping or something else?
Yes it comes from I/O space remapping.
The fill error log:
CC drivers/pci/host/pci-tegra.o
In file included from ./arch/arm/include/asm/page.h:22:0,
from ./arch/arm/include/asm/thread_info.h:17,
from ./include/linux/thread_info.h:58,
from ./include/asm-generic/current.h:4,
from ./arch/arm/include/generated/asm/current.h:1,
from ./include/linux/mutex.h:13,
from ./include/linux/notifier.h:13,
from ./include/linux/clk.h:17,
from drivers/pci/host/pci-tegra.c:29:
drivers/pci/host/pci-tegra.c: In function 'tegra_pcie_bus_alloc':
drivers/pci/host/pci-tegra.c:388:27: error: 'L_PTE_PRESENT' undeclared (first use in this function)
pgprot_t prot = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c:388:27: note: each undeclared identifier is reported only once for each function it appears in
pgprot_t prot = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c:388:43: error: 'L_PTE_YOUNG' undeclared (first use in this function)
pgprot_t prot = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c:388:57: error: 'L_PTE_DIRTY' undeclared (first use in this function)
pgprot_t prot = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c:389:6: error: 'L_PTE_XN' undeclared (first use in this function)
L_PTE_XN | L_PTE_MT_DEV_SHARED | L_PTE_SHARED);
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c:389:17: error: 'L_PTE_MT_DEV_SHARED' undeclared (first use in this function)
L_PTE_XN | L_PTE_MT_DEV_SHARED | L_PTE_SHARED);
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c:389:39: error: 'L_PTE_SHARED' undeclared (first use in this function)
L_PTE_XN | L_PTE_MT_DEV_SHARED | L_PTE_SHARED);
^
./arch/arm/include/asm/page-nommu.h:41:26: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
drivers/pci/host/pci-tegra.c: At top level:
drivers/pci/host/pci-tegra.c:501:10: error: 'pci_generic_config_read32' undeclared here (not in a function)
.read = pci_generic_config_read32,
^
drivers/pci/host/pci-tegra.c:502:11: error: 'pci_generic_config_write32' undeclared here (not in a function)
.write = pci_generic_config_write32,
^
drivers/pci/host/pci-tegra.c: In function 'tegra_pcie_relax_enable':
drivers/pci/host/pci-tegra.c:609:2: error: implicit declaration of function 'pcie_capability_set_word' [-Werror=implicit-function-declaration]
pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_DEVCTL_RELAX_EN);
^
drivers/pci/host/pci-tegra.c: In function 'tegra_pcie_setup':
drivers/pci/host/pci-tegra.c:626:8: error: implicit declaration of function 'pci_remap_iospace' [-Werror=implicit-function-declaration]
err = pci_remap_iospace(&pcie->pio, pcie->io.start);
^
drivers/pci/host/pci-tegra.c:628:3: error: implicit declaration of function 'pci_add_resource_offset' [-Werror=implicit-function-declaration]
pci_add_resource_offset(&sys->resources, &pcie->pio,
^
drivers/pci/host/pci-tegra.c:634:2: error: implicit declaration of function 'pci_add_resource' [-Werror=implicit-function-declaration]
pci_add_resource(&sys->resources, &pcie->busn);
^
drivers/pci/host/pci-tegra.c:636:8: error: implicit declaration of function 'devm_request_pci_bus_resources' [-Werror=implicit-function-declaration]
err = devm_request_pci_bus_resources(dev, &sys->resources);
^
cc1: some warnings being treated as errors
make[1]: *** [drivers/pci/host/pci-tegra.o] Error 1
make: *** [drivers/pci/host/pci-tegra.o] Error 2
Cheers
Vladimir
>
> Arnd
>
>
next prev parent reply other threads:[~2016-11-22 9:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 9:25 [RFC PATCH 00/11] Allow NOMMU for MULTIPLATFORM Vladimir Murzin
2016-11-22 9:25 ` [RFC PATCH 01/11] ARM: NOMMU: define stubs for fixup Vladimir Murzin
2016-11-22 9:48 ` Russell King - ARM Linux
2016-11-22 9:54 ` Vladimir Murzin
2016-11-22 9:25 ` [RFC PATCH 02/11] ARM: ep93xx: select ARM_PATCH_PHYS_VIRT for MMU builds only Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 03/11] ARM: omap: do not select HIGHMEM explicitly Vladimir Murzin
2016-11-22 9:51 ` Russell King - ARM Linux
2016-11-23 15:49 ` Tony Lindgren
2016-11-23 16:08 ` Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 04/11] PCI: tegra: limit to MMU build only Vladimir Murzin
2016-11-22 9:31 ` Arnd Bergmann
2016-11-22 9:40 ` Vladimir Murzin [this message]
2016-11-22 9:54 ` Arnd Bergmann
2016-11-22 9:58 ` Vladimir Murzin
2016-11-22 11:26 ` Thierry Reding
2016-11-25 10:49 ` Vladimir Murzin
2016-11-22 16:15 ` Stephen Warren
2016-11-22 21:16 ` Arnd Bergmann
2016-11-22 22:27 ` Stephen Warren
2016-11-22 22:52 ` Arnd Bergmann
2016-11-22 9:26 ` [RFC PATCH 05/11] ARM: move arm_heavy_mb to MMU/noMMU neutral place Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 06/11] ARM: tlbflush: drop dependency on CONFIG_SMP Vladimir Murzin
2016-11-22 10:03 ` Russell King - ARM Linux
2016-11-22 13:36 ` Vladimir Murzin
2016-11-24 17:41 ` Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 07/11] ARM: sleep: allow it to be build for R-class Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 08/11] ARM: NOMMU: define debug_ll_io_ini Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 09/11] ARM: NOMMU: define SECTION_xxx macros Vladimir Murzin
2016-11-22 10:07 ` Russell King - ARM Linux
2016-11-22 11:50 ` Vladimir Murzin
2016-11-22 11:54 ` Russell King - ARM Linux
2016-11-22 17:03 ` Vladimir Murzin
2016-11-24 17:38 ` Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 10/11] ARM: NOMMU: define __arm_ioremap_exec and pci_ioremap functions Vladimir Murzin
2016-11-22 9:26 ` [RFC PATCH 11/11] ARM: Allow ARCH_MULTIPLATFORM to be selected for NOMMU Vladimir Murzin
2016-11-22 10:17 ` Arnd Bergmann
2016-11-22 16:57 ` Vladimir Murzin
2016-11-23 15:48 ` Afzal Mohammed
2016-11-23 16:07 ` Vladimir Murzin
2016-11-24 17:28 ` Afzal Mohammed
2016-11-24 17:33 ` Vladimir Murzin
2016-11-24 18:09 ` Afzal Mohammed
2016-11-23 19:16 ` Russell King - ARM Linux
2016-11-24 17:25 ` Afzal Mohammed
2016-11-24 17:35 ` Russell King - ARM Linux
2016-11-24 18:07 ` Afzal Mohammed
2016-11-24 18:45 ` Russell King - ARM Linux
2016-11-25 11:20 ` Vladimir Murzin
2016-11-23 15:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58341297.9090303@arm.com \
--to=vladimir.murzin@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox