From: cw00.choi@samsung•com (Chanwoo Choi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] usb: musb: sunxi: Uses the resource-managed extcon API when registering extcon notifier
Date: Tue, 10 Jan 2017 17:20:38 +0900 [thread overview]
Message-ID: <58749956.1030800@samsung.com> (raw)
In-Reply-To: <1483071550-8683-1-git-send-email-cw00.choi@samsung.com>
Hi Felipe,
This patch got the acked-by from Bin Liu and.
Could you please apply this patch?
On 2016? 12? 30? 13:19, Chanwoo Choi wrote:
> This patch just uses the resource-managed extcon API when registering
> the extcon notifier.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung•com>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons•com>
> Acked-by: Bin Liu <b-liu@ti•com>
> ---
> Changes from v1:
> - Rebase this patch based on v4.10-rc1.
> - Add acked-by tag from Maxime Ripard and Bin Lin.
> - Drop the phy/power-supply/chipidea patches.
>
> drivers/usb/musb/sunxi.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index d0be0eadd0d9..2332294dee0f 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -251,14 +251,14 @@ static int sunxi_musb_init(struct musb *musb)
> writeb(SUNXI_MUSB_VEND0_PIO_MODE, musb->mregs + SUNXI_MUSB_VEND0);
>
> /* Register notifier before calling phy_init() */
> - ret = extcon_register_notifier(glue->extcon, EXTCON_USB_HOST,
> - &glue->host_nb);
> + ret = devm_extcon_register_notifier(glue->dev, glue->extcon,
> + EXTCON_USB_HOST, &glue->host_nb);
> if (ret)
> goto error_reset_assert;
>
> ret = phy_init(glue->phy);
> if (ret)
> - goto error_unregister_notifier;
> + goto error_reset_assert;
>
> musb->isr = sunxi_musb_interrupt;
>
> @@ -267,9 +267,6 @@ static int sunxi_musb_init(struct musb *musb)
>
> return 0;
>
> -error_unregister_notifier:
> - extcon_unregister_notifier(glue->extcon, EXTCON_USB_HOST,
> - &glue->host_nb);
> error_reset_assert:
> if (test_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags))
> reset_control_assert(glue->rst);
> @@ -293,9 +290,6 @@ static int sunxi_musb_exit(struct musb *musb)
>
> phy_exit(glue->phy);
>
> - extcon_unregister_notifier(glue->extcon, EXTCON_USB_HOST,
> - &glue->host_nb);
> -
> if (test_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags))
> reset_control_assert(glue->rst);
>
>
--
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics
next prev parent reply other threads:[~2017-01-10 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161230041914epcas5p24826e70fd5de710818687e55579757ba@epcas5p2.samsung.com>
2016-12-30 4:19 ` [PATCH v2] usb: musb: sunxi: Uses the resource-managed extcon API when registering extcon notifier Chanwoo Choi
2017-01-10 8:20 ` Chanwoo Choi [this message]
2017-01-10 20:47 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58749956.1030800@samsung.com \
--to=cw00.choi@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox