public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: guohanjun@huawei•com (Hanjun Guo)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] arch_timer: acpi: add hisi timer erratum data
Date: Wed, 22 Feb 2017 15:41:02 +0800	[thread overview]
Message-ID: <58AD408E.5080409@huawei.com> (raw)
In-Reply-To: <874lzn602f.fsf@on-the-bus.cambridge.arm.com>

On 2017/2/21 23:22, Marc Zyngier wrote:
> On Tue, Feb 21 2017 at 11:56:31 am GMT, Hanjun Guo <guohanjun@huawei•com> wrote:
>> Hi Marc,
> [...]
>
[...]
>>
>> And I got compile errors for this patch [1], seems "#include <linux/acpi.h>" in
>> arch/arm64/include/asm/arch_timer.h triggers the problem of head
>> file inclusions (too early to include <linux/sched.h>?), I'm looking into it,
>> if you can help to take a look too, that will be great :)
> This is really much more complicated (and uglier) than what I had in
> mind, and I don't want to add more cruft to the erratum description
> structure. So instead of trying to explain what I wanted to see, here's
> the patches I whipped together.
>
> Please let me know if they work for you (as I have no way of testing
> them).
>
> Thanks,
>
> 	M.
>
> >From 50eb735436f9f6482285939b39b52d858d848537 Mon Sep 17 00:00:00 2001
> From: Marc Zyngier <marc.zyngier@arm•com>
> Date: Tue, 21 Feb 2017 14:37:30 +0000
> Subject: [PATCH 1/2] arm64: arch_timer: Allow erratum matching with ACPI OEM
>  information
>
> Just as we're able to identify a broken platform using some DT
> information, let's enable a way to spot the offenders with ACPI.
>
> The difference is that we can only match on some OEM info instead
> of implementation-specific properties. So in order to avoid the
> insane multiplication of errata structures, we allow an array
> of OEM descriptions to be attached to an erratum structure.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm•com>
> ---
>  arch/arm64/include/asm/arch_timer.h  |  1 +
>  drivers/clocksource/arm_arch_timer.c | 33 +++++++++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+)

Marc, thank you for the help, I tested your patches on D03, I got:

[    0.000000] arm_arch_timer: Enabling global workaround for HiSilicon erratum 161010101
[    0.000000] arm_arch_timer: CPU0: Trapping CNTVCT access

in the boot log, which means the framework and ACPI patches work fine.

Thanks
Hanjun

  parent reply	other threads:[~2017-02-22  7:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 10:39 [PATCH 0/2] arch_timer: acpi: Add workaround for hisilicon-161010101 erratum Hanjun Guo
2017-01-24 10:39 ` [PATCH 1/2] arm64: arch_timer: acpi: Introduce a generic aquirk framework for erratum Hanjun Guo
2017-01-24 10:39 ` [PATCH 2/2] arch_timer: acpi: add hisi timer erratum data Hanjun Guo
2017-01-24 10:57   ` Mark Rutland
2017-01-24 11:32     ` Marc Zyngier
2017-01-24 12:35       ` John Garry
2017-01-24 13:08         ` Marc Zyngier
2017-01-24 13:28           ` Shameerali Kolothum Thodi
2017-01-24 13:22       ` Hanjun Guo
2017-02-10  7:10       ` Hanjun Guo
2017-02-16  8:42         ` Alexander Graf
2017-02-16  9:14           ` Daniel Lezcano
2017-02-16  9:32             ` Alexander Graf
2017-02-16  9:41               ` Ding Tianhong
2017-02-16  9:46                 ` Sanil Kumar
2017-02-16  9:49                   ` Daniel Lezcano
2017-02-16  9:42             ` Hanjun Guo
2017-02-16 10:04         ` Marc Zyngier
2017-02-20 19:00         ` Marc Zyngier
2017-02-21 11:56           ` Hanjun Guo
2017-02-21 15:22             ` Marc Zyngier
2017-02-22  4:08               ` Alexander Graf
2017-02-22  9:29                 ` Marc Zyngier
2017-02-22  7:41               ` Hanjun Guo [this message]
2017-02-21 12:46           ` Ding Tianhong
2017-01-24 13:50     ` Hanjun Guo
2017-01-24 10:49 ` [PATCH 0/2] arch_timer: acpi: Add workaround for hisilicon-161010101 erratum Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58AD408E.5080409@huawei.com \
    --to=guohanjun@huawei$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox