From: jeffy.chen@rock-chips•com (jeffy)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence
Date: Wed, 05 Apr 2017 18:20:34 +0800 [thread overview]
Message-ID: <58E4C4F2.7090306@rock-chips.com> (raw)
In-Reply-To: <20170404194426.e7pxf4kj5lbkvp6s@art_vandelay>
Hi Sean,
On 04/05/2017 03:44 AM, Sean Paul wrote:
> On Sat, Apr 01, 2017 at 07:35:26PM +0800, Jeffy Chen wrote:
>> We should not cleanup iommu before cleanup other resources.
>>
>> Reorder unload sequence, follow exynos drm.
>
> This doesn't match the cleanup sequence in rockchip_drm_bind. Also make sure
> that you're unwinding the setup sequence when you cleanup (ie: take a close look
> at how you set things up and reverse it for cleanup).
ok, will reoder the bind sequence too, thanx.
>
> Sean
>
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips•com>
>> ---
>>
>> Changes in v2: None
>>
>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> index b360e62..a5d83cb 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> @@ -244,11 +244,13 @@ static void rockchip_drm_unbind(struct device *dev)
>> struct drm_device *drm_dev = dev_get_drvdata(dev);
>>
>> rockchip_drm_fbdev_fini(drm_dev);
>> - drm_vblank_cleanup(drm_dev);
>> drm_kms_helper_poll_fini(drm_dev);
>> +
>> + drm_vblank_cleanup(drm_dev);
>> component_unbind_all(dev, drm_dev);
>> - rockchip_iommu_cleanup(drm_dev);
>> drm_mode_config_cleanup(drm_dev);
>> + rockchip_iommu_cleanup(drm_dev);
>> +
>> drm_dev->dev_private = NULL;
>> drm_dev_unregister(drm_dev);
>> drm_dev_unref(drm_dev);
>> --
>> 2.1.4
>>
>
next prev parent reply other threads:[~2017-04-05 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 11:35 [PATCH v2 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
2017-04-01 11:35 ` [PATCH v2 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen
2017-04-01 11:35 ` [PATCH v2 5/9] drm/rockchip: vop: Enable pm domain when resetting vop Jeffy Chen
2017-04-04 19:42 ` Sean Paul
2017-04-05 10:23 ` jeffy
2017-04-01 11:35 ` [PATCH v2 6/9] drm/rockchip: Reoder unload sequence Jeffy Chen
2017-04-04 19:44 ` Sean Paul
2017-04-05 10:20 ` jeffy [this message]
2017-04-01 11:35 ` [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload Jeffy Chen
2017-04-03 7:58 ` Daniel Vetter
2017-04-05 10:25 ` jeffy
2017-04-01 11:35 ` [PATCH v2 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Jeffy Chen
2017-04-03 7:41 ` Daniel Vetter
2017-04-05 1:28 ` jeffy
2017-04-01 11:35 ` [PATCH v2 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E4C4F2.7090306@rock-chips.com \
--to=jeffy.chen@rock-chips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox