From: Hugues FRUCHET <hugues.fruchet@st•com>
To: Markus Elfring <Markus.Elfring@web•de>,
"linux-media@vger•kernel.org" <linux-media@vger•kernel.org>,
"linux-stm32@st-md-mailman•stormreply.com"
<linux-stm32@st-md-mailman•stormreply.com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
Alexandre TORGUE <alexandre.torgue@st•com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>
Cc: "kernel-janitors@vger•kernel.org"
<kernel-janitors@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] media: stm32-dcmi: Delete an unnecessary of_node_put() call in dcmi_probe()
Date: Mon, 2 Sep 2019 09:41:14 +0000 [thread overview]
Message-ID: <58d7d520-ba18-a822-4920-2bedb0d01203@st.com> (raw)
In-Reply-To: <129a4933-2171-7ed9-c84c-8e56b6d05270@web.de>
Acked-by: Hugues Fruchet <hugues.fruchet@st•com>
On 8/27/19 4:09 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users•sourceforge.net>
> Date: Tue, 27 Aug 2019 16:00:13 +0200
>
> A null pointer would be passed to a call of the function “of_node_put”
> immediately after a call of the function “of_graph_get_next_endpoint”
> failed at one place.
> Remove this superfluous function call.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users•sourceforge.net>
> ---
> drivers/media/platform/stm32/stm32-dcmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index cb1daf8217ff..9392e3409fba 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1861,7 +1861,6 @@ static int dcmi_probe(struct platform_device *pdev)
> np = of_graph_get_next_endpoint(np, NULL);
> if (!np) {
> dev_err(&pdev->dev, "Could not find the endpoint\n");
> - of_node_put(np);
> return -ENODEV;
> }
>
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-02 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 14:09 [PATCH] media: stm32-dcmi: Delete an unnecessary of_node_put() call in dcmi_probe() Markus Elfring
2019-09-02 9:41 ` Hugues FRUCHET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d7d520-ba18-a822-4920-2bedb0d01203@st.com \
--to=hugues.fruchet@st$(echo .)com \
--cc=Markus.Elfring@web$(echo .)de \
--cc=alexandre.torgue@st$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mchehab@kernel$(echo .)org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox