From: Alexander Sverdlin <alexander.sverdlin@gmail•com>
To: wens@kernel•org
Cc: Andre Przywara <andre.przywara@arm•com>,
linux-sunxi@lists•linux.dev, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Samuel Holland <samuel@sholland•org>,
devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board
Date: Mon, 18 May 2026 12:12:43 +0200 [thread overview]
Message-ID: <58e882977f7b4297e67d785467ec681c43ce3606.camel@gmail.com> (raw)
In-Reply-To: <CAGb2v67tjOCE=Xk=pD84wBG4WTt1nYhDoW3gu_xfx4J0Ooc_VQ@mail.gmail.com>
Hi Checn-Yu,
thanks for the review!
On Mon, 2026-05-18 at 11:30 +0800, Chen-Yu Tsai wrote:
> > > And you should provide a top level 5V regulator here, to be the root of
> > > the regulator tree. Look at reg_vcc5v in the Liontron .dts.
> >
> > It doesn't look to me as if Liontron had reg_vcc5v as its 5V "root" regulator.
> > It seems to be only used for reg_usb1_vbus, while HelperBoard A133 doesn't
> > have USB power control. The second issue with Helper/Core split is that
> > all PMIC story is inside Core board which has 5V input rail, while HelperBoard
> > around it has indeed 12V->5V DCDC regulator (similar to Liontron), but
> > putting it in the DT would introduce wierd dependency of the core to the
> > HelperBoard which carries it. Do you think it would make sense?
>
> In that case I would probably put a 5v "fake root" regulator in the core
> dtsi. And in combined dts, I'd then add the 12v "real root", and use that
> as the supply for the 5v fake root.
>
> Does that make sense?
"core" board has some battery management schematics, switching the 5V,
I'll look into specifying this part in "core" .dtsi, maybe it will result
in some kind of regulator in "core" part. I'll send v4.
--
Alexander Sverdlin.
next prev parent reply other threads:[~2026-05-18 10:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 20:16 [PATCH v2 0/3] Add support for Baijie Helper A133 board Alexander Sverdlin
2026-05-10 20:16 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Shenzhen Baijie Technology Co., Ltd Alexander Sverdlin
2026-05-18 11:36 ` Paul Kocialkowski
2026-05-10 20:16 ` [PATCH v2 2/3] dt-bindings: arm: sunxi: Add Baijie HelperBoard A133 compatible Alexander Sverdlin
2026-05-11 16:08 ` Conor Dooley
2026-05-11 16:18 ` Alexander Sverdlin
2026-05-11 16:34 ` Conor Dooley
2026-05-18 11:35 ` Paul Kocialkowski
2026-05-10 20:16 ` [PATCH v2 3/3] arm64: dts: allwinner: A133: add support for Baijie Helper A133 board Alexander Sverdlin
2026-05-11 11:44 ` Andre Przywara
2026-05-17 20:38 ` Alexander Sverdlin
2026-05-18 3:30 ` Chen-Yu Tsai
2026-05-18 10:12 ` Alexander Sverdlin [this message]
2026-05-18 11:16 ` Andre Przywara
2026-05-18 11:29 ` Alexander Sverdlin
2026-05-18 11:54 ` Paul Kocialkowski
2026-05-18 12:50 ` Andre Przywara
2026-05-18 14:47 ` Chen-Yu Tsai
2026-05-18 14:51 ` Alexander Sverdlin
2026-05-18 11:52 ` Paul Kocialkowski
2026-05-18 12:09 ` Alexander Sverdlin
2026-05-18 14:14 ` Paul Kocialkowski
2026-05-18 14:40 ` Alexander Sverdlin
2026-05-18 14:56 ` Paul Kocialkowski
2026-05-18 15:04 ` Alexander Sverdlin
2026-05-18 21:23 ` Andre Przywara
2026-05-18 20:05 ` Alexander Sverdlin
2026-05-18 21:46 ` Paul Kocialkowski
2026-05-19 3:33 ` Chen-Yu Tsai
2026-05-18 21:54 ` Andre Przywara
2026-06-04 22:37 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58e882977f7b4297e67d785467ec681c43ce3606.camel@gmail.com \
--to=alexander.sverdlin@gmail$(echo .)com \
--cc=andre.przywara@arm$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=robh@kernel$(echo .)org \
--cc=samuel@sholland$(echo .)org \
--cc=wens@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox