From: Suzuki K Poulose <suzuki.poulose@arm•com>
To: mike.leach@linaro•org, mathieu.poirier@linaro•org,
linux-arm-kernel@lists•infradead.org, coresight@lists•linaro.org,
linux-doc@vger•kernel.org
Cc: gregkh@linuxfoundation•org, corbet@lwn•net
Subject: Re: [PATCH v2 02/11] coresight: etm4x: Fix input validation for sysfs.
Date: Tue, 17 Sep 2019 10:33:56 +0100 [thread overview]
Message-ID: <596f7e12-3ce4-45f6-b30b-713b2bd1f1fa@arm.com> (raw)
In-Reply-To: <20190829213321.4092-3-mike.leach@linaro.org>
On 29/08/2019 22:33, Mike Leach wrote:
> A number of issues are fixed relating to sysfs input validation:-
>
> 1) bb_ctrl_store() - incorrect compare of bit select field to absolute
> value. Reworked per ETMv4 specification.
> 2) seq_event_store() - incorrect mask value - register has two
> event values.
> 3) cyc_threshold_store() - must mask with max before checking min
> otherwise wrapped values can set illegal value below min.
> 4) res_ctrl_store() - update to mask off all res0 bits.
>
> Reviewed-by: Leo Yan <leo.yan@linaro•org>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro•org>
> Signed-off-by: Mike Leach <mike.leach@linaro•org>
Does this need to goto stable ? May be add a Fixes tag ? It fixes real
issues with the values that could be programmed into these registers.
Cheers
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-17 9:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 21:33 [PATCH v2 00/11] coresight: etm4x: Fixes and updates for sysfs API Mike Leach
2019-08-29 21:33 ` [PATCH v2 01/11] coresight: etm4x: Fixes for ETM v4.4 architecture updates Mike Leach
2019-08-29 21:33 ` [PATCH v2 02/11] coresight: etm4x: Fix input validation for sysfs Mike Leach
2019-09-17 9:33 ` Suzuki K Poulose [this message]
2019-08-29 21:33 ` [PATCH v2 03/11] coresight: etm4x: Add missing API to set EL match on address filters Mike Leach
2019-09-17 9:31 ` Suzuki K Poulose
2019-10-26 20:26 ` [PATCH] coresight: etm4x: Fix BMVAL misuse Rikard Falkeborn
2019-10-30 15:19 ` Mathieu Poirier
2019-08-29 21:33 ` [PATCH v2 04/11] coresight: etm4x: Fix issues with start-stop logic Mike Leach
2019-08-29 21:33 ` [PATCH v2 05/11] coresight: etm4x: Improve usability of sysfs - include/exclude addr Mike Leach
2019-08-29 21:33 ` [PATCH v2 06/11] coresight: etm4x: Improve usability of sysfs - CID and VMID masks Mike Leach
2019-08-29 21:33 ` [PATCH v2 07/11] coresight: etm4x: Add view comparator settings API to sysfs Mike Leach
2019-08-29 21:33 ` [PATCH v2 08/11] coresight: etm4x: Add missing single-shot control " Mike Leach
2019-08-29 21:33 ` [PATCH v2 09/11] coresight: etm4x: docs: Update ABI doc for sysfs features added Mike Leach
2019-09-03 19:42 ` Mathieu Poirier
2019-09-03 19:59 ` Greg KH
2019-09-03 22:51 ` Mathieu Poirier
2019-09-04 5:48 ` Greg KH
2019-09-04 16:05 ` Mathieu Poirier
2019-09-04 16:17 ` Greg KH
2019-09-04 19:47 ` Mathieu Poirier
2019-08-29 21:33 ` [PATCH v2 10/11] coresight: docs: Create common sub-directory for coresight trace Mike Leach
2019-08-29 21:33 ` [PATCH v2 11/11] coresight: etm4x: docs: Adds detailed document for programming etm4x Mike Leach
2019-09-03 19:38 ` Mathieu Poirier
2019-09-03 22:46 ` Mike Leach
2019-09-04 16:09 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596f7e12-3ce4-45f6-b30b-713b2bd1f1fa@arm.com \
--to=suzuki.poulose@arm$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=coresight@lists$(echo .)linaro.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=mike.leach@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox