* [PATCH v11 0/3]add PCIe driver for Kirin PCIe [not found] <20170619102349.50652-1-songxiaowei@hisilicon.com> @ 2017-07-02 23:36 ` Bjorn Helgaas 2017-07-03 10:47 ` Will Deacon 0 siblings, 1 reply; 7+ messages in thread From: Bjorn Helgaas @ 2017-07-02 23:36 UTC (permalink / raw) To: linux-arm-kernel [+cc Catalin, Will, linux-arm-kernel] Applied patches 2 & 3 to pci/host-kirin for v4.13. I would like a MAINTAINERS update, too. If you send me that, I'll squash it into the driver patch. Catalin, Will, how do you want to handle the arch/arm64/configs/defconfig change (patch 3)? It's currently on my branch, but I'm happy to drop it if another route is better. On Mon, Jun 19, 2017 at 06:23:46PM +0800, Xiaowei Song wrote: > Before Version Patches > ====================== > patch v9 > http://www.spinics.net/lists/linux-pci/msg61821.html > patch V8 > http://www.spinics.net/lists/linux-pci/msg61715.html > patch V7 > https://www.spinics.net/lists/linux-pci/msg61664.html > patch V6 > https://www.spinics.net/lists/linux-pci/msg61610.html > > patch V4 > https://www.spinics.net/lists/linux-pci/msg61406.html > > patch V3 > https://www.spinics.net/lists/linux-pci/msg61399.html > > Changes between V11 and V9 > ======================== > 1. Fix the indent issues according to the review comments from Bjorn: > (1) The value of reg is right-aligned in both dtsi file and Documentation file. > (2) Re-indent the space of macro defination pointed out by Bjorn. > (3) Adjust the space in 'struct kirin_pcie' defination. > (4) Use dev replace of pdev->dev in function kirin_pcie_get_clk and kirin_pcie_get_resource. > (5) Aligned params with '(' in function kirin_apb_ctrl_writel and several others. > 2. Fix the issues that compitable value in Documentation was different with .dtsi file. > 3. For dependance during compiling, the dtsi patch is deleted, and it was merged in patch[1]. > 4. The indent style issues will be pull with MSI-patch in the next weeks; > > patch[1]: https://www.spinics.net/lists/arm-kernel/msg588944.html > > ========================= > Changes between V8 and V7 > ========================= > 1. Fix the indent issues in Documentation, dtsi file and macro defination. > 2. Replace pdev->dev with dev in kirin_pcie_get_resource and > kirin_pcie_get_clk functions. > 3. Put variables "pci" and "kirin_pcie" to be initialized at first > in kirin_pcie_wr_own_config, kirin_pcie_read_dbi and other functions. > 4. Add space before blankets in "Low power mode(L1 ". > 5. Short the Makefile sentence to lower than 80 characters > and delete reduntant words. > 6. Use word 'located' instead of the wrong one 'lacated'. > 7. Fix the problem of return value type. > > Changes between V8 and V7 > ========================= > 1. Replace 'reset-gpios' of 'reset-gpio' in Documentation. > > Changes between V7 and V6 > ========================= > 1. add enumeration log Based on Hikey960 Board with these patches. > 2. fix issues as fellows: > (1) delete reduntant blankets in macro defination, > (2) add blank line in kirin_pcie_clk_ctrl function. > (3) Fix compitable property in DT with the SoC name, > for example "hisilicon,kirin960-pcie". > > Changes between V6 and V4 > ========================= > 1. seperate Document from .dtsi patch. > 2. fix issues according to review comments > from Bjorn Helgaas and Rob Herring: annotation stype, DT node, > patch post method and so on. > > Enumeration log > =============== > These test logs come from patches running on Hikey960 Board > (1) Connect with Atheros Communications WIFI > OF: PCI: host bridge /soc/kirin_pcie_rc at f4000000 ranges: > OF: PCI: MEM 0xf6000000..0xf7ffffff -> 0x00000000 > kirin-pcie f4000000.kirin_pcie_rc: PCI host bridge to bus 0000:00 > pci_bus 0000:00: root bus resource [bus 00-01] > pci_bus 0000:00: root bus resource [mem 0xf6000000-0xf7ffffff] (bus address [0x00000000-0x01ffffff]) > pci 0000:00:00.0: [19e5:3660] type 01 class 0x060400 > pci 0000:00:00.0: reg 0x10: [mem 0xf6000000-0xf6ffffff] > pci 0000:00:00.0: supports D1 D2 > pci 0000:00:00.0: PME# supported from D0 D1 D2 D3hot > pci 0000:01:00.0: [168c:002a] type 00 class 0x028000 > pci 0000:01:00.0: reg 0x10: [mem 0xf6000000-0xf600ffff 64bit] > pci 0000:01:00.0: supports D1 > pci 0000:01:00.0: PME# supported from D0 D1 D3hot > pci 0000:01:00.0: disabling ASPM on pre-1.1 PCIe device. You can enable it with 'pcie_aspm=force' > pci 0000:00:00.0: BAR 0: assigned [mem 0xf6000000-0xf6ffffff] > pci 0000:00:00.0: BAR 14: assigned [mem 0xf7000000-0xf70fffff] > pci 0000:01:00.0: BAR 0: assigned [mem 0xf7000000-0xf700ffff 64bit] > pci 0000:00:00.0: PCI bridge to [bus 01] > pci 0000:00:00.0: bridge window [mem 0xf7000000-0xf70fffff] > pcieport 0000:00:00.0: Signaling PME with IRQ 276 > pcieport 0000:00:00.0: AER enabled with IRQ 276 > > > Xiaowei Song (3): > PCI: hisi: Add DT binding for PCIe of Kirin SoC series > PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC > ARM4: defconfig: Enable Kirin PCIe > > .../devicetree/bindings/pci/kirin-pcie.txt | 55 +++ > arch/arm64/configs/defconfig | 1 + > drivers/pci/dwc/Kconfig | 10 + > drivers/pci/dwc/Makefile | 1 + > drivers/pci/dwc/pcie-kirin.c | 518 +++++++++++++++++++++ > 5 files changed, 585 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/kirin-pcie.txt > create mode 100644 drivers/pci/dwc/pcie-kirin.c > > -- > 2.11.GIT > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v11 0/3]add PCIe driver for Kirin PCIe 2017-07-02 23:36 ` [PATCH v11 0/3]add PCIe driver for Kirin PCIe Bjorn Helgaas @ 2017-07-03 10:47 ` Will Deacon 2017-07-03 12:55 ` Bjorn Helgaas 2017-07-03 13:04 ` Guodong Xu 0 siblings, 2 replies; 7+ messages in thread From: Will Deacon @ 2017-07-03 10:47 UTC (permalink / raw) To: linux-arm-kernel On Sun, Jul 02, 2017 at 06:36:57PM -0500, Bjorn Helgaas wrote: > [+cc Catalin, Will, linux-arm-kernel] > > Applied patches 2 & 3 to pci/host-kirin for v4.13. > > I would like a MAINTAINERS update, too. If you send me that, I'll > squash it into the driver patch. > > Catalin, Will, how do you want to handle the > arch/arm64/configs/defconfig change (patch 3)? It's currently on my > branch, but I'm happy to drop it if another route is better. defconfig updates usually go through arm-soc, via the relevant platform maintainer, so it would be best to follow that route here too otherwise you'll probably see conflicts in -next. Will ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v11 0/3]add PCIe driver for Kirin PCIe 2017-07-03 10:47 ` Will Deacon @ 2017-07-03 12:55 ` Bjorn Helgaas 2017-07-03 13:04 ` Guodong Xu 1 sibling, 0 replies; 7+ messages in thread From: Bjorn Helgaas @ 2017-07-03 12:55 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 03, 2017 at 11:47:27AM +0100, Will Deacon wrote: > On Sun, Jul 02, 2017 at 06:36:57PM -0500, Bjorn Helgaas wrote: > > [+cc Catalin, Will, linux-arm-kernel] > > > > Applied patches 2 & 3 to pci/host-kirin for v4.13. > > > > I would like a MAINTAINERS update, too. If you send me that, I'll > > squash it into the driver patch. > > > > Catalin, Will, how do you want to handle the > > arch/arm64/configs/defconfig change (patch 3)? It's currently on my > > branch, but I'm happy to drop it if another route is better. > > defconfig updates usually go through arm-soc, via the relevant platform > maintainer, so it would be best to follow that route here too otherwise > you'll probably see conflicts in -next. OK, dropped the defconfig change and updated my -next branch. I'm still looking for a MAINTAINERS update. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v11 0/3]add PCIe driver for Kirin PCIe 2017-07-03 10:47 ` Will Deacon 2017-07-03 12:55 ` Bjorn Helgaas @ 2017-07-03 13:04 ` Guodong Xu 2017-07-03 13:32 ` Wei Xu 1 sibling, 1 reply; 7+ messages in thread From: Guodong Xu @ 2017-07-03 13:04 UTC (permalink / raw) To: linux-arm-kernel Hi, Xu Wei On Mon, Jul 3, 2017 at 6:47 PM, Will Deacon <will.deacon@arm•com> wrote: > On Sun, Jul 02, 2017 at 06:36:57PM -0500, Bjorn Helgaas wrote: >> [+cc Catalin, Will, linux-arm-kernel] >> >> Applied patches 2 & 3 to pci/host-kirin for v4.13. >> >> I would like a MAINTAINERS update, too. If you send me that, I'll >> squash it into the driver patch. >> >> Catalin, Will, how do you want to handle the >> arch/arm64/configs/defconfig change (patch 3)? It's currently on my >> branch, but I'm happy to drop it if another route is better. > > defconfig updates usually go through arm-soc, via the relevant platform > maintainer, so it would be best to follow that route here too otherwise > you'll probably see conflicts in -next. > Is it ok for you to pick up the arch/arm64/configs/defconfig change (patch 3)? -Guodong > Will ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v11 0/3]add PCIe driver for Kirin PCIe 2017-07-03 13:04 ` Guodong Xu @ 2017-07-03 13:32 ` Wei Xu 2017-07-04 2:03 ` Guodong Xu 0 siblings, 1 reply; 7+ messages in thread From: Wei Xu @ 2017-07-03 13:32 UTC (permalink / raw) To: linux-arm-kernel Hi Guodong, On 2017/7/3 14:04, Guodong Xu wrote: > Hi, Xu Wei > > > > On Mon, Jul 3, 2017 at 6:47 PM, Will Deacon <will.deacon@arm•com> wrote: >> On Sun, Jul 02, 2017 at 06:36:57PM -0500, Bjorn Helgaas wrote: >>> [+cc Catalin, Will, linux-arm-kernel] >>> >>> Applied patches 2 & 3 to pci/host-kirin for v4.13. >>> >>> I would like a MAINTAINERS update, too. If you send me that, I'll >>> squash it into the driver patch. >>> >>> Catalin, Will, how do you want to handle the >>> arch/arm64/configs/defconfig change (patch 3)? It's currently on my >>> branch, but I'm happy to drop it if another route is better. >> >> defconfig updates usually go through arm-soc, via the relevant platform >> maintainer, so it would be best to follow that route here too otherwise >> you'll probably see conflicts in -next. >> > > Is it ok for you to pick up the arch/arm64/configs/defconfig change (patch 3)? Since it is already 4.12-rc7, I will pick up it and queue for the v4.14. Are you fine about that? Thanks! Best Regards, Wei > > -Guodong > >> Will > > . > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v11 0/3]add PCIe driver for Kirin PCIe 2017-07-03 13:32 ` Wei Xu @ 2017-07-04 2:03 ` Guodong Xu 2017-08-15 13:28 ` Wei Xu 0 siblings, 1 reply; 7+ messages in thread From: Guodong Xu @ 2017-07-04 2:03 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jul 3, 2017 at 9:32 PM, Wei Xu <xuwei5@hisilicon•com> wrote: > Hi Guodong, > > On 2017/7/3 14:04, Guodong Xu wrote: >> Hi, Xu Wei >> >> >> >> On Mon, Jul 3, 2017 at 6:47 PM, Will Deacon <will.deacon@arm•com> wrote: >>> On Sun, Jul 02, 2017 at 06:36:57PM -0500, Bjorn Helgaas wrote: >>>> [+cc Catalin, Will, linux-arm-kernel] >>>> >>>> Applied patches 2 & 3 to pci/host-kirin for v4.13. >>>> >>>> I would like a MAINTAINERS update, too. If you send me that, I'll >>>> squash it into the driver patch. >>>> >>>> Catalin, Will, how do you want to handle the >>>> arch/arm64/configs/defconfig change (patch 3)? It's currently on my >>>> branch, but I'm happy to drop it if another route is better. >>> >>> defconfig updates usually go through arm-soc, via the relevant platform >>> maintainer, so it would be best to follow that route here too otherwise >>> you'll probably see conflicts in -next. >>> >> >> Is it ok for you to pick up the arch/arm64/configs/defconfig change (patch 3)? > > Since it is already 4.12-rc7, I will pick up it and queue for the v4.14. > Are you fine about that? > Thanks! Sure. > > Best Regards, > Wei > >> >> -Guodong >> >>> Will >> >> . >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v11 0/3]add PCIe driver for Kirin PCIe 2017-07-04 2:03 ` Guodong Xu @ 2017-08-15 13:28 ` Wei Xu 0 siblings, 0 replies; 7+ messages in thread From: Wei Xu @ 2017-08-15 13:28 UTC (permalink / raw) To: linux-arm-kernel Hi Guodong, On 2017/7/4 3:03, Guodong Xu wrote: > On Mon, Jul 3, 2017 at 9:32 PM, Wei Xu <xuwei5@hisilicon•com> wrote: >> Hi Guodong, >> >> On 2017/7/3 14:04, Guodong Xu wrote: >>> Hi, Xu Wei >>> >>> >>> >>> On Mon, Jul 3, 2017 at 6:47 PM, Will Deacon <will.deacon@arm•com> wrote: >>>> On Sun, Jul 02, 2017 at 06:36:57PM -0500, Bjorn Helgaas wrote: >>>>> [+cc Catalin, Will, linux-arm-kernel] >>>>> >>>>> Applied patches 2 & 3 to pci/host-kirin for v4.13. >>>>> >>>>> I would like a MAINTAINERS update, too. If you send me that, I'll >>>>> squash it into the driver patch. >>>>> >>>>> Catalin, Will, how do you want to handle the >>>>> arch/arm64/configs/defconfig change (patch 3)? It's currently on my >>>>> branch, but I'm happy to drop it if another route is better. >>>> >>>> defconfig updates usually go through arm-soc, via the relevant platform >>>> maintainer, so it would be best to follow that route here too otherwise >>>> you'll probably see conflicts in -next. >>>> >>> >>> Is it ok for you to pick up the arch/arm64/configs/defconfig change (patch 3)? >> >> Since it is already 4.12-rc7, I will pick up it and queue for the v4.14. >> Are you fine about that? >> Thanks! > > Sure. Applied the patch 3 into the hisilicon defconfig tree. BR, Wei > >> >> Best Regards, >> Wei >> >>> >>> -Guodong >>> >>>> Will >>> >>> . >>> >> > > . > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-15 13:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170619102349.50652-1-songxiaowei@hisilicon.com>
2017-07-02 23:36 ` [PATCH v11 0/3]add PCIe driver for Kirin PCIe Bjorn Helgaas
2017-07-03 10:47 ` Will Deacon
2017-07-03 12:55 ` Bjorn Helgaas
2017-07-03 13:04 ` Guodong Xu
2017-07-03 13:32 ` Wei Xu
2017-07-04 2:03 ` Guodong Xu
2017-08-15 13:28 ` Wei Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox