From: mathias.nyman@linux•intel.com (Mathias Nyman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3][for 4.14] xhci: allow TRACE to work with EVENT ring dequeue
Date: Thu, 5 Oct 2017 12:52:41 +0300 [thread overview]
Message-ID: <59D600E9.7010105@linux.intel.com> (raw)
In-Reply-To: <3100d137-d581-665f-9665-561578a61ac8@codeaurora.org>
On 04.10.2017 19:07, Adam Wallis wrote:
> On 9/26/2017 2:44 AM, Mathias Nyman wrote:
>> On 25.09.2017 19:09, David Laight wrote:
>>> From: Adam Wallis
>>>> Sent: 25 September 2017 13:26
>>>> inc_deq() currently bails earlier for EVENT rings than the common return
>>>> point of the function, due to the fact that EVENT rings do not have
>>>> link TRBs. The unfortunate side effect of this is that the very useful
>>>> trace_xhci_inc_deq() function is not called/usable for EVENT ring
>>>> debug.
>>>
>>> Is it actually worth using different functions for the different
>>> ring types?
>>> From what I remember there are conditionals in a lot of the functions
>>> but they are fixed for most of the call sites.
>>>
>>
>> There's some restructuring and refactoring that could be done in xhci,
>> but that's not part of this patch.
>>
>> This will just enable better debugging.
>>
>> Applying this patch
> Sounds great, thanks! Will this be going in on 4.14 sometime shortly? I hadn't
> seen it in your tree and was curious since we are tracking internally. Thanks!
>
Now pushed to my for-usb-next branch and sent forward to Greg.
On its way to 4.15
-Mathias
prev parent reply other threads:[~2017-10-05 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:26 [PATCH v3][for 4.14] xhci: allow TRACE to work with EVENT ring dequeue Adam Wallis
2017-09-25 16:09 ` David Laight
2017-09-25 17:03 ` Adam Wallis
2017-09-26 6:44 ` Mathias Nyman
2017-10-04 16:07 ` Adam Wallis
2017-10-05 9:52 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59D600E9.7010105@linux.intel.com \
--to=mathias.nyman@linux$(echo .)intel.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox