From: Wei Xu <xuwei5@hisilicon•com>
To: Serge Semin <Sergey.Semin@baikalelectronics•ru>,
Felipe Balbi <balbi@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Florian Fainelli <f.fainelli@gmail•com>,
Rob Herring <robh+dt@kernel•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
Serge Semin <fancer.lancer@gmail•com>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 06/18] arm64: dts: hisi: Harmonize EHCI/OHCI DT nodes name
Date: Wed, 25 Nov 2020 10:27:10 +0800 [thread overview]
Message-ID: <5FBDC0FE.5060409@hisilicon.com> (raw)
In-Reply-To: <20201111091552.15593-7-Sergey.Semin@baikalelectronics.ru>
Hi Serge,
On 2020/11/11 17:15, Serge Semin wrote:
> In accordance with the Generic EHCI/OHCI bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
> nodes are correctly named.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics•ru>
> Acked-by: Krzysztof Kozlowski <krzk@kernel•org>
> ---
> arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
> arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++--
> arch/arm64/boot/dts/hisilicon/hip07.dtsi | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
> index 12bc1d3ed424..a4acecb75c89 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
> @@ -585,7 +585,7 @@ pcie: pcie@9860000 {
> status = "disabled";
> };
>
> - ohci: ohci@9880000 {
> + ohci: usb@9880000 {
> compatible = "generic-ohci";
> reg = <0x9880000 0x10000>;
> interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> @@ -600,7 +600,7 @@ ohci: ohci@9880000 {
> status = "disabled";
> };
>
> - ehci: ehci@9890000 {
> + ehci: usb@9890000 {
> compatible = "generic-ehci";
> reg = <0x9890000 0x10000>;
> interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> index 50ceaa959bdc..1226440d54ad 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> @@ -373,7 +373,7 @@ refclk: refclk {
> #clock-cells = <0>;
> };
>
> - usb_ohci: ohci@a7030000 {
> + usb_ohci: usb@a7030000 {
> compatible = "generic-ohci";
> reg = <0x0 0xa7030000 0x0 0x10000>;
> interrupt-parent = <&mbigen_usb>;
> @@ -382,7 +382,7 @@ usb_ohci: ohci@a7030000 {
> status = "disabled";
> };
>
> - usb_ehci: ehci@a7020000 {
> + usb_ehci: usb@a7020000 {
> compatible = "generic-ehci";
> reg = <0x0 0xa7020000 0x0 0x10000>;
> interrupt-parent = <&mbigen_usb>;
> diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> index 4773a533fce5..93f99a5255ac 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> @@ -1253,7 +1253,7 @@ uart0: uart@602b0000 {
> status = "disabled";
> };
>
> - usb_ohci: ohci@a7030000 {
> + usb_ohci: usb@a7030000 {
> compatible = "generic-ohci";
> reg = <0x0 0xa7030000 0x0 0x10000>;
> interrupt-parent = <&mbigen_usb>;
> @@ -1262,7 +1262,7 @@ usb_ohci: ohci@a7030000 {
> status = "disabled";
> };
>
> - usb_ehci: ehci@a7020000 {
> + usb_ehci: usb@a7020000 {
> compatible = "generic-ehci";
> reg = <0x0 0xa7020000 0x0 0x10000>;
> interrupt-parent = <&mbigen_usb>;
>
Thanks!
But a similar patch has been sent out earlier:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201012131739.1655-8-thunder.leizhen@huawei.com/
Best Regards,
Wei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-25 2:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201111091552.15593-1-Sergey.Semin@baikalelectronics.ru>
2020-11-11 9:15 ` [PATCH v2 01/18] arm: dts: keystone: Correct DWC USB3 compatible string Serge Semin
2020-11-11 9:15 ` [PATCH v2 02/18] arm64: dts: amlogic: meson-g12: Set FL-adj property value Serge Semin
2020-11-11 9:15 ` [PATCH v2 04/18] arm: dts: hisi-x5hd2: Harmonize EHCI/OHCI DT nodes name Serge Semin
2020-11-25 2:27 ` Wei Xu
2020-11-11 9:15 ` [PATCH v2 05/18] arm: dts: lpc18xx: " Serge Semin
2020-11-11 9:15 ` [PATCH v2 06/18] arm64: dts: hisi: " Serge Semin
2020-11-25 2:27 ` Wei Xu [this message]
2020-11-11 9:15 ` [PATCH v2 09/18] mips: dts: ralink: mt7628a: " Serge Semin
2020-11-12 22:41 ` Thomas Bogendoerfer
2020-11-11 9:15 ` [PATCH v2 11/18] arm64: dts: marvell: cp11x: Harmonize xHCI " Serge Semin
2020-11-30 14:23 ` Gregory CLEMENT
2020-11-11 9:15 ` [PATCH v2 12/18] arm: dts: marvell: armada-375: Harmonize DWC USB3 " Serge Semin
2020-11-30 14:22 ` Gregory CLEMENT
2020-11-11 9:15 ` [PATCH v2 13/18] arm: dts: keystone: " Serge Semin
2020-11-11 9:15 ` [PATCH v2 14/18] arm: dts: stih407-family: " Serge Semin
2020-11-11 9:15 ` [PATCH v2 16/18] arm64: dts: hi3660: " Serge Semin
2020-11-25 2:23 ` Wei Xu
2020-12-19 5:11 ` John Stultz
2020-12-19 11:06 ` Krzysztof Kozlowski
2020-12-21 20:24 ` John Stultz
2020-12-21 21:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FBDC0FE.5060409@hisilicon.com \
--to=xuwei5@hisilicon$(echo .)com \
--cc=Sergey.Semin@baikalelectronics$(echo .)ru \
--cc=balbi@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fancer.lancer@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox