From: Enric Balletbo i Serra <enric.balletbo@collabora•com>
To: Randy Dunlap <rdunlap@infradead•org>,
robh+dt@kernel•org, mark.rutland@arm•com, ck.hu@mediatek•com,
p.zabel@pengutronix•de, airlied@linux•ie,
mturquette@baylibre•com, sboyd@kernel•org,
ulrich.hecht+renesas@gmail•com,
laurent.pinchart@ideasonboard•com
Cc: Kate Stewart <kstewart@linuxfoundation•org>,
Andrew-CT Chen <andrew-ct.chen@mediatek•com>,
Minghsiu Tsai <minghsiu.tsai@mediatek•com>,
dri-devel@lists•freedesktop.org,
Richard Fontana <rfontana@redhat•com>,
Collabora Kernel ML <kernel@collabora•com>,
linux-clk@vger•kernel.org, Weiyi Lu <weiyi.lu@mediatek•com>,
wens@csie•org, linux-arm-kernel@lists•infradead.org,
mtk01761 <wendell.lin@mediatek•com>,
linux-media@vger•kernel.org, devicetree@vger•kernel.org,
frank-w@public-files•de, Seiya Wang <seiya.wang@mediatek•com>,
sean.wang@mediatek•com, Houlong Wei <houlong.wei@mediatek•com>,
linux-mediatek@lists•infradead.org, hsinyi@chromium•org,
Matthias Brugger <matthias.bgg@gmail•com>,
Thomas Gleixner <tglx@linutronix•de>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Allison Randal <allison@lohutok•net>,
Matthias Brugger <mbrugger@suse•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-kernel@vger•kernel.org, Daniel Vetter <daniel@ffwll•ch>,
matthias.bgg@kernel•org
Subject: Re: [PATCH v8 1/6] drm/mediatek: Use regmap for register access
Date: Fri, 21 Feb 2020 08:46:29 +0100 [thread overview]
Message-ID: <5c19af7a-170b-2cd1-da98-e4125504eb34@collabora.com> (raw)
In-Reply-To: <0b2046b9-90de-c894-7502-993b5df12e7a@infradead.org>
Hi Randy,
On 21/2/20 0:48, Randy Dunlap wrote:
> On 2/20/20 9:21 AM, Enric Balletbo i Serra wrote:
>> From: Matthias Brugger <mbrugger@suse•com>
>>
>> The mmsys memory space is shared between the drm and the
>> clk driver. Use regmap to access it.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse•com>
>> Reviewed-by: Philipp Zabel <p.zabel@pengutronix•de>
>> Reviewed-by: CK Hu <ck.hu@mediatek•com>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora•com>
>> ---
>>
>> Changes in v8: None
>> Changes in v7:
>> - Add R-by from CK
>>
>> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +-
>> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 50 +++++++++++--------------
>> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +-
>> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 13 ++-----
>> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +-
>> 5 files changed, 30 insertions(+), 43 deletions(-)
>
> Hi. Just a quick question:
>
> Do you need to select REGMAP or one of its derivatives to make sure
> that the proper interfaces are available for this driver?
>
Right, I will fix this in next version.
> thanks.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-21 7:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:21 [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys device probing Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 1/6] drm/mediatek: Use regmap for register access Enric Balletbo i Serra
2020-02-20 23:48 ` Randy Dunlap
2020-02-21 7:46 ` Enric Balletbo i Serra [this message]
2020-02-20 17:21 ` [PATCH v8 2/6] drm/mediatek: Omit warning on probe defers Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 3/6] media: mtk-mdp: Check return value of of_clk_get Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 4/6] clk: mediatek: mt8173: Switch MMSYS to platform driver Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 5/6] drm/mediatek: Move MMSYS configuration to include/linux/platform_data Enric Balletbo i Serra
2020-02-20 17:21 ` [PATCH v8 6/6] clk/drm: mediatek: Fix mediatek-drm device probing Enric Balletbo i Serra
2020-02-21 5:18 ` CK Hu
2020-02-21 7:51 ` Enric Balletbo i Serra
2020-02-21 4:39 ` [PATCH v8 0/6] arm/arm64: mediatek: Fix mmsys " CK Hu
2020-02-21 8:56 ` Enric Balletbo i Serra
2020-02-21 9:27 ` CK Hu
2020-02-21 10:24 ` Matthias Brugger
2020-02-21 11:11 ` CK Hu
2020-02-21 11:37 ` Enric Balletbo i Serra
2020-02-21 11:53 ` Matthias Brugger
2020-02-21 17:10 ` Enric Balletbo i Serra
2020-02-24 5:52 ` CK Hu
2020-02-25 10:56 ` Enric Balletbo i Serra
2020-02-26 5:32 ` CK Hu
2020-02-26 9:24 ` Enric Balletbo i Serra
2020-02-21 10:20 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c19af7a-170b-2cd1-da98-e4125504eb34@collabora.com \
--to=enric.balletbo@collabora$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=allison@lohutok$(echo .)net \
--cc=andrew-ct.chen@mediatek$(echo .)com \
--cc=ck.hu@mediatek$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=frank-w@public-files$(echo .)de \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=houlong.wei@mediatek$(echo .)com \
--cc=hsinyi@chromium$(echo .)org \
--cc=kernel@collabora$(echo .)com \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=matthias.bgg@kernel$(echo .)org \
--cc=mbrugger@suse$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=minghsiu.tsai@mediatek$(echo .)com \
--cc=mturquette@baylibre$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=rdunlap@infradead$(echo .)org \
--cc=rfontana@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=sean.wang@mediatek$(echo .)com \
--cc=seiya.wang@mediatek$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=ulrich.hecht+renesas@gmail$(echo .)com \
--cc=weiyi.lu@mediatek$(echo .)com \
--cc=wendell.lin@mediatek$(echo .)com \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox