Subject: Re: [PATCH v6 10/10] mm/memory_hotplug: Cleanup __remove_pages()

From: David Hildenbrand <[email-masked]>
Date: Tue, 4 Feb 2020 13:41:06 +0100

On 04.02.20 10:46, Oscar Salvador wrote:
> On Sun, Oct 06, 2019 at 10:56:46AM +0200, David Hildenbrand wrote:
>> Let's drop the basically unused section stuff and simplify.
>>
>> Also, let's use a shorter variant to calculate the number of pages to
>> the next section boundary.
>>
>> Cc: Andrew Morton <[email-masked]>
>> Cc: Oscar Salvador <[email-masked]>
>> Cc: Michal Hocko <[email-masked]>
>> Cc: Pavel Tatashin <[email-masked]>
>> Cc: Dan Williams <[email-masked]>
>> Cc: Wei Yang <[email-masked]>
>> Signed-off-by: David Hildenbrand <[email-masked]>
> 
> I have to confess that it took me while to wrap around my head
> with the new min() change, but looks ok:

It's a pattern commonly used in compilers and emulators to calculate the
number of bytes to the next block/alignment. (we're missing a macro
(like we have ALIGN_UP/IS_ALIGNED) for that - but it's hard to come up
with a good name (e.g., SIZE_TO_NEXT_ALIGN) .

-- 
Thanks,

David / dhildenb

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel