From: Heiko Stuebner <heiko@sntech•de>
To: hjc@rock-chips•com, andy.yan@rock-chips•com,
maarten.lankhorst@linux•intel.com, mripard@kernel•org,
tzimmermann@suse•de, airlied@gmail•com, simona@ffwll•ch,
robh@kernel•org, krzk+dt@kernel•org, conor+dt@kernel•org,
andrzej.hajda@intel•com, neil.armstrong@linaro•org,
rfoss@kernel•org, Damon Ding <damon.ding@rock-chips•com>
Cc: Laurent.pinchart@ideasonboard•com, jonas@kwiboo•se,
jernej.skrabec@gmail•com, nicolas.frattaroli@collabora•com,
cristian.ciocaltea@collabora•com,
sebastian.reichel@collabora•com,
dmitry.baryshkov@oss•qualcomm.com, luca.ceresoli@bootlin•com,
dianders@chromium•org, m.szyprowski@samsung•com,
dri-devel@lists•freedesktop.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org, linux-kernel@vger•kernel.org,
Damon Ding <damon.ding@rock-chips•com>
Subject: Re: [PATCH v3 01/10] dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock
Date: Thu, 07 May 2026 13:40:09 +0200 [thread overview]
Message-ID: <6496645.8F6SAcFxjW@phil> (raw)
In-Reply-To: <20260507112948.1115003-2-damon.ding@rock-chips.com>
Hi Damon,
Am Donnerstag, 7. Mai 2026, 13:29:39 Mitteleuropäische Sommerzeit schrieb Damon Ding:
> The RK3588 eDP controller needs the video datapath clock "hclk" to work
> well. Previously, it works without explicitly adding this clock because
> the 'rockchip,vo-grf = <&vo1_grf>' property implicitly enables HCLK_VO1.
>
> Fixes: f855146263b1 ("dt-bindings: display: rockchip: analogix-dp: Add support for RK3588")
> Signed-off-by: Damon Ding <damon.ding@rock-chips•com>
> ---
> .../bindings/display/rockchip/rockchip,analogix-dp.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index d99b23b88cc5..d2bc8636b626 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> @@ -26,7 +26,9 @@ properties:
> items:
> - const: dp
> - const: pclk
> - - const: grf
> + - enum:
> + - grf
> + - hclk
are you sure about that?
The edp uses the vo1-grf - so what enables its clock?
For example the hdmi controllers on rk3588 also use the vo1-grf and
explicitly handle that clock.
So who does it for the eDP?
Heiko
>
> power-domains:
> maxItems: 1
>
next prev parent reply other threads:[~2026-05-07 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 11:29 [PATCH v3 00/10] Add eDP support for RK3576 Damon Ding
2026-05-07 11:29 ` [PATCH v3 01/10] dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock Damon Ding
2026-05-07 11:40 ` Heiko Stuebner [this message]
2026-05-07 11:42 ` Heiko Stuebner
2026-05-08 1:37 ` Damon Ding
2026-05-07 11:29 ` [PATCH v3 02/10] dt-bindings: display: rockchip: analogix-dp: Add descriptions for clocks Damon Ding
2026-05-07 11:29 ` [PATCH v3 03/10] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP0 nodes Damon Ding
2026-05-07 11:29 ` [PATCH v3 04/10] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP1 nodes Damon Ding
2026-05-07 11:29 ` [PATCH v3 05/10] drm/rockchip: analogix_dp: Enable clock "hclk" for RK3588 Damon Ding
2026-05-07 11:29 ` [PATCH v3 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-07 11:29 ` [PATCH v3 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-07 11:29 ` [PATCH v3 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-07 11:29 ` [PATCH v3 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-07 11:29 ` [PATCH v3 10/10] drm/rockchip: " Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6496645.8F6SAcFxjW@phil \
--to=heiko@sntech$(echo .)de \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=cristian.ciocaltea@collabora$(echo .)com \
--cc=damon.ding@rock-chips$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=hjc@rock-chips$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=luca.ceresoli@bootlin$(echo .)com \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=nicolas.frattaroli@collabora$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=sebastian.reichel@collabora$(echo .)com \
--cc=simona@ffwll$(echo .)ch \
--cc=tzimmermann@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox