From: Tomi Valkeinen <tomi.valkeinen@ti•com>
To: Andreas Kemnade <andreas@kemnade•info>,
Laurent Pinchart <laurent.pinchart@ideasonboard•com>
Cc: Tony Lindgren <tony@atomide•com>,
Linux-OMAP <linux-omap@vger•kernel.org>,
Discussions about the Letux Kernel <letux-kernel@openphoenux•org>,
linux-arm-kernel <linux-arm-kernel@lists•infradead.org>,
Jyri Sarha <jsarha@ti•com>
Subject: Re: [Letux-kernel] [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
Date: Mon, 7 Oct 2019 17:29:20 +0300 [thread overview]
Message-ID: <654d00a7-d802-d116-84c4-7c614d0fe272@ti.com> (raw)
In-Reply-To: <20191007064035.72016c78@aktux>
On 07/10/2019 07:40, Andreas Kemnade wrote:
>>> That's really weird, the driver name, the SPI device table and the OF
>>> device table are the same (except for the "omapdss," prefix that we
>>> don't add anymore in omapdss-boot-init.c). Would you be able to
>>> investigate what broke ?
>>>
>> in earlier times:
>>
>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
>> spi:tpo,td028ttec1
>>
>> now in 5.4-rc1:
>> root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias
>> spi:td028ttec1
>>
>> root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
>> filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko
>> license: GPL
>> description: Toppoly TD028TTEC1 panel driver
>> author: H. Nikolaus Schaller <hns@goldelico•com>
>> srcversion: 6B3E224BCD3D76253CF361C
>> alias: of:N*T*Ctoppoly,td028ttec1C*
>> alias: of:N*T*Ctoppoly,td028ttec1
>> alias: of:N*T*Ctpo,td028ttec1C*
>> alias: of:N*T*Ctpo,td028ttec1
>> alias: spi:toppoly,td028ttec1
>> alias: spi:tpo,td028ttec1
>> depends: drm
>> intree: Y
>> name: panel_tpo_td028ttec1
>> vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
>>
>> That alias is not in the list.
>>
> some more research:
> in former times
> of_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1
> now it strips the tpo prefix because there is no omapdss prefix anymore.
I haven't studied this more yet, but yes, I can see of_modalias_node
stripping the vendor prefix on purpose. I do wonder how this is supposed
to work, it would make more sense to me to keep the vendor prefix.
Is the spi_device_id supposed to be without vendor prefix? With a quick
grep, this seems to be the case.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-07 14:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 16:55 [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes Tony Lindgren
2019-10-04 8:41 ` Tomi Valkeinen
2019-10-04 15:54 ` Tony Lindgren
2019-10-07 6:13 ` Tomi Valkeinen
2019-10-05 10:50 ` H. Nikolaus Schaller
2019-10-06 14:53 ` Laurent Pinchart
2019-10-06 15:07 ` H. Nikolaus Schaller
2019-10-06 20:39 ` [Letux-kernel] " Andreas Kemnade
2019-10-07 4:40 ` Andreas Kemnade
2019-10-07 14:29 ` Tomi Valkeinen [this message]
2019-10-07 16:09 ` Andreas Kemnade
2019-10-07 17:08 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=654d00a7-d802-d116-84c4-7c614d0fe272@ti.com \
--to=tomi.valkeinen@ti$(echo .)com \
--cc=andreas@kemnade$(echo .)info \
--cc=jsarha@ti$(echo .)com \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=letux-kernel@openphoenux$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox