From: Andrew Jeffery <andrew@codeconstruct•com.au>
To: "P.K. Lee" <pkleequanta@gmail•com>,
robh+dt@kernel•org, krzysztof.kozlowski+dt@linaro•org,
conor+dt@kernel•org, joel@jms•id.au, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-aspeed@lists•ozlabs.org, linux-kernel@vger•kernel.org
Cc: Jason-Hsu@quantatw•com, p.k.lee@quantatw•com
Subject: Re: [PATCH v13 0/2] Add Meta (Facebook) Ventura BMC (AST2600)
Date: Mon, 18 May 2026 21:57:59 +0930 [thread overview]
Message-ID: <663d06c8c42892586075ddb2ba7111b06c58752f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260407081700.2658011-1-pkleequanta@gmail.com>
Hi P.K.,
On Tue, 2026-04-07 at 16:16 +0800, P.K. Lee wrote:
> Add Linux device tree entry related to Meta (Facebook) Ventura specific
> devices connected to the BMC (AST2600) SoC. The purpose of Ventura is to
> detect liquid leakage from all compute trays, switch trays and rack
> sensors within the rack, log the events, and take necessary actions
> accordingly.
>
...
> ---
>
> P.K. Lee (2):
> dt-bindings: arm: aspeed: add Meta Ventura board
> arm: dts: aspeed: ventura: add Meta Ventura BMC
A few things on the commit subjects. Can you please:
- Capitalise the first word of the short description (the word after
the final colon)
- For the DTS patch, capitalise 'ARM' for consistency
- Avoid redundancies
So:
dt-bindings: arm: aspeed: Add Meta Ventura board
ARM: dts: aspeed: Add Meta Ventura BMC
Cheers,
Andrew
prev parent reply other threads:[~2026-05-18 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 8:16 [PATCH v13 0/2] Add Meta (Facebook) Ventura BMC (AST2600) P.K. Lee
2026-04-07 8:16 ` [PATCH v13 1/2] dt-bindings: arm: aspeed: add Meta Ventura board P.K. Lee
2026-04-07 8:17 ` [PATCH v13 2/2] arm: dts: aspeed: ventura: add Meta Ventura BMC P.K. Lee
2026-05-18 12:22 ` Andrew Jeffery
2026-05-19 12:16 ` P.K. Lee
2026-05-18 12:27 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663d06c8c42892586075ddb2ba7111b06c58752f.camel@codeconstruct.com.au \
--to=andrew@codeconstruct$(echo .)com.au \
--cc=Jason-Hsu@quantatw$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=joel@jms$(echo .)id.au \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=p.k.lee@quantatw$(echo .)com \
--cc=pkleequanta@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox