Subject: Re: [PATCH] arm64: dts: hisilicon: poplar: Correct PCIe reset GPIO polarity

From: Wei Xu <[email-masked]>
Date: Sat, 21 Mar 2026 14:51:20 +0800

Hi Shawn,

On 2026/2/27 15:19, Shawn Guo wrote:
> The PCIe reset GPIO on Poplar is actually active low.  The active high
> worked before because kernel driver didn't respect the setting from DT.
> This is changed since commit 1d26a55fbeb9 ("PCI: histb: Switch to using
> gpiod API"), and thus PCIe on Poplar got brken since then.
> 
> Fix the problem by correcting the polarity.
> 
> Fixes: 32fa01761bd9 ("arm64: dts: hi3798cv200: enable PCIe support for poplar board")
> Cc: [email-masked]
> Signed-off-by: Shawn Guo <[email-masked]>
> ---
>  arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> index 7d370dac4c85..579d55daa7d0 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200-poplar.dts
> @@ -179,7 +179,7 @@ &ohci {
>  };
>  
>  &pcie {
> -	reset-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
> +	reset-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;
>  	vpcie-supply = <&reg_pcie>;
>  	status = "okay";
>  };
> 

Applied to the HiSilicon arm64 dt tree.
Thanks!

Best Regards,
Wei