From: Rolf Eike Beer <eike-kernel@sf-tec•de>
To: Mike Rapoport <rppt@kernel•org>
Cc: linux-parisc-owner@vger•kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
linux-mm@kvack•org, sparclinux@vger•kernel.org,
Vincent Chen <deanbo422@gmail•com>,
Greg Ungerer <gerg@linux-m68k•org>,
Anton Ivanov <anton.ivanov@cambridgegreys•com>,
linux-arch@vger•kernel.org, linux-c6x-dev@linux-c6x•org,
Richard Weinberger <richard@nod•at>, Helge Deller <deller@gmx•de>,
Russell King <linux@armlinux•org.uk>,
Mike Rapoport <rppt@linux•ibm.com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Mark Salter <msalter@redhat•com>,
Matt Turner <mattst88@gmail•com>, Jeff Dike <jdike@addtoit•com>,
Sam Creasey <sammy@sammy•net>, Arnd Bergmann <arnd@arndb•de>,
Vineet Gupta <Vineet.Gupta1@synopsys•com>,
linux-um@lists•infradead.org, linux-m68k@lists•linux-m68k.org,
Greentime Hu <green.hu@gmail•com>,
"Kirill A. Shutemov" <kirill@shutemov•name>,
linux-arm-kernel@lists•infradead.org,
Michal Simek <monstr@monstr•eu>,
linux-parisc@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-alpha@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
Linus Torvalds <torvalds@linux-foundation•org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 08/12] parisc: use pgtable-nopXd instead of 4level-fixup
Date: Wed, 23 Oct 2019 12:20:29 +0200 [thread overview]
Message-ID: <70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de> (raw)
In-Reply-To: <1571822941-29776-9-git-send-email-rppt@kernel.org>
> diff --git a/arch/parisc/include/asm/page.h
> b/arch/parisc/include/asm/page.h
> index 93caf17..1d339ee 100644
> --- a/arch/parisc/include/asm/page.h
> +++ b/arch/parisc/include/asm/page.h
> @@ -42,48 +42,54 @@ typedef struct { unsigned long pte; } pte_t; /*
> either 32 or 64bit */
>
> /* NOTE: even on 64 bits, these entries are __u32 because we allocate
> * the pmd and pgd in ZONE_DMA (i.e. under 4GB) */
> -typedef struct { __u32 pmd; } pmd_t;
> typedef struct { __u32 pgd; } pgd_t;
> typedef struct { unsigned long pgprot; } pgprot_t;
>
> -#define pte_val(x) ((x).pte)
> -/* These do not work lvalues, so make sure we don't use them as such.
> */
> +#if CONFIG_PGTABLE_LEVELS == 3
> +typedef struct { __u32 pmd; } pmd_t;
> +#define __pmd(x) ((pmd_t) { (x) } )
> +/* pXd_val() do not work lvalues, so make sure we don't use them as
> such. */
For me it sounds like there is something missing, maybe an "as" before
lvalues?
And it was "These", so plural, and now it is singular, so do -> does?
Eike
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-23 10:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:28 [PATCH 00/12] mm: remove __ARCH_HAS_4LEVEL_HACK Mike Rapoport
2019-10-23 9:28 ` [PATCH 01/12] alpha: use pgtable-nop4d instead of 4level-fixup Mike Rapoport
2019-10-23 9:28 ` [PATCH 02/12] arm: nommu: use pgtable-nopud " Mike Rapoport
2019-10-23 9:40 ` Russell King - ARM Linux admin
2019-10-23 9:28 ` [PATCH 03/12] c6x: " Mike Rapoport
2019-10-23 9:28 ` [PATCH 04/12] m68k: nommu: " Mike Rapoport
2019-10-24 4:09 ` Greg Ungerer
2019-10-24 5:35 ` Mike Rapoport
2019-10-24 6:23 ` Greg Ungerer
2019-10-23 9:28 ` [PATCH 05/12] m68k: mm: use pgtable-nopXd " Mike Rapoport
2019-10-24 4:12 ` Greg Ungerer
2019-10-25 5:52 ` kbuild test robot
2019-10-23 9:28 ` [PATCH 06/12] microblaze: use pgtable-nopmd " Mike Rapoport
2019-10-25 2:17 ` kbuild test robot
2019-10-25 8:24 ` Michal Simek
2019-10-25 20:33 ` Mike Rapoport
2019-10-23 9:28 ` [PATCH 07/12] nds32: " Mike Rapoport
2019-10-23 9:28 ` [PATCH 08/12] parisc: use pgtable-nopXd " Mike Rapoport
2019-10-23 10:20 ` Rolf Eike Beer [this message]
2019-10-24 8:51 ` Mike Rapoport
2019-10-24 9:35 ` Peter Rosin
2019-10-24 9:50 ` Mike Rapoport
2019-10-23 9:28 ` [PATCH 09/12] sparc32: use pgtable-nopud " Mike Rapoport
2019-10-23 19:59 ` [PATCH v2 " Mike Rapoport
2019-10-23 21:21 ` David Miller
2019-10-23 9:28 ` [PATCH 10/12] um: remove unused pxx_offset_proc() and addr_pte() functions Mike Rapoport
2019-10-23 9:29 ` [PATCH 11/12] um: add support for folded p4d page tables Mike Rapoport
2019-10-23 9:29 ` [PATCH 12/12] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Mike Rapoport
2019-10-23 10:25 ` [PATCH 00/12] mm: remove __ARCH_HAS_4LEVEL_HACK Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70339cfc547e2fa0f6b98fefb1b1a9fa@sf-tec.de \
--to=eike-kernel@sf-tec$(echo .)de \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=Vineet.Gupta1@synopsys$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anton.ivanov@cambridgegreys$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=deanbo422@gmail$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=geert@linux-m68k$(echo .)org \
--cc=gerg@linux-m68k$(echo .)org \
--cc=green.hu@gmail$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc-owner@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mattst88@gmail$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=msalter@redhat$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=rppt@kernel$(echo .)org \
--cc=rppt@linux$(echo .)ibm.com \
--cc=sammy@sammy$(echo .)net \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox