Re: [PATCH] ARM: mach-imx6q: add ksz9131rn_phy_fixup

From: Ahmad Fatoum <a.fatoum@pengutronix•de>
To: Andrew Lunn <andrew@lunn•ch>, Oleksij Rempel <o.rempel@pengutronix•de>
Cc: Kate Stewart <kstewart@linuxfoundation•org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Sascha Hauer <s.hauer@pengutronix•de>,
	Russell King <linux@armlinux•org.uk>,
	linux-kernel@vger•kernel.org,
	Philippe Schenker <philippe.schenker@toradex•com>,
	NXP Linux Team <linux-imx@nxp•com>,
	Pengutronix Kernel Team <kernel@pengutronix•de>,
	Shawn Guo <shawnguo@kernel•org>,
	Thomas Gleixner <tglx@linutronix•de>,
	Fabio Estevam <festevam@gmail•com>,
	Allison Randal <allison@lohutok•net>,
	linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] ARM: mach-imx6q: add ksz9131rn_phy_fixup
Date: Fri, 6 Mar 2020 08:42:47 +0100	[thread overview]
Message-ID: <7191ffe6-642a-477c-ec37-e37dc9be4bf8@pengutronix.de> (raw)
In-Reply-To: <20200305165145.GA25183@lunn.ch>

Hello Andrew,

On 3/5/20 5:51 PM, Andrew Lunn wrote:
> On Thu, Mar 05, 2020 at 03:38:05PM +0100, Oleksij Rempel wrote:
>> Hi Philippe,
>>
>> On Thu, Mar 05, 2020 at 02:49:28PM +0100, Philippe Schenker wrote:
>>> The MAC of the i.MX6 SoC is compliant with RGMII v1.3. The KSZ9131 PHY
>>> is like KSZ9031 adhering to RGMII v2.0 specification. This means the
>>> MAC should provide a delay to the TXC line. Because the i.MX6 MAC does
>>> not provide this delay this has to be done in the PHY.
>>>
>>> This patch adds by default ~1.6ns delay to the TXC line. This should
>>> be good for all boards that have the RGMII signals routed with the
>>> same length.
>>>
>>> The KSZ9131 has relatively high tolerances on skew registers from
>>> MMD 2.4 to MMD 2.8. Therefore the new DLL-based delay of 2ns is used
>>> and then as little as possibly subtracted from that so we get more
>>> accurate delay. This is actually needed because the i.MX6 SoC has
>>> an asynchron skew on TXC from -100ps to 900ps, to get all RGMII
>>> values within spec.
>>
>> This configuration has nothing to do in mach-imx/* It belongs to the
>> board devicetree. Please see DT binding documentation for needed
>> properties:
>> Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> 
> It probably does not even need that. Just
> 
> phy-mode = <rgmii-txid>

Looks to me like this isn't supported by the Micrel PHY driver or am
I missing something?

Cheers
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel