From: Alexander Lobakin <aleksander.lobakin@intel•com>
To: Lorenzo Bianconi <lorenzo@kernel•org>
Cc: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>,
<linux-arm-kernel@lists•infradead.org>,
<linux-mediatek@lists•infradead.org>, <netdev@vger•kernel.org>,
Xuegang Lu <xuegang.lu@airoha•com>
Subject: Re: [PATCH net-next 1/6] net: airoha: Introduce airoha_gdm_dev struct
Date: Fri, 29 May 2026 17:04:37 +0200 [thread overview]
Message-ID: <722f177c-0578-4b0b-b2fa-2acd45b2e299@intel.com> (raw)
In-Reply-To: <ahhonoI-oJ6gJqZ0@lore-desk>
From: Lorenzo Bianconi <lorenzo@kernel•org>
Date: Thu, 28 May 2026 18:09:02 +0200
> On May 28, Alexander Lobakin wrote:
>> From: Lorenzo Bianconi <lorenzo@kernel•org>
>> Date: Wed, 27 May 2026 12:21:15 +0200
>>
>>> EN7581 and AN7583 SoCs support connecting multiple external SerDes to GDM3
>>> or GDM4 ports via a hw arbiter that manages the traffic in a TDM manner.
>>> As a result multiple net_devices can connect to the same GDM{3,4} port
>>> and there is a theoretical "1:n" relation between GDM port and
>>> net_devices.
>>> Introduce airoha_gdm_dev struct to collect net_device related info (e.g.
>>> net_device and external phy pointer). Please note this is just a
>>> preliminary patch and we are still supporting a single net_device for
>>> each GDM port. Subsequent patches will add support for multiple net_devices
>>> connected to the same GDM port.
>>>
>>> Tested-by: Xuegang Lu <xuegang.lu@airoha•com>
>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel•org>
>>
>> [...]
>>
>>> diff --git a/drivers/net/ethernet/airoha/airoha_eth.h b/drivers/net/ethernet/airoha/airoha_eth.h
>>> index d3781103abb5..c78cabbec753 100644
>>> --- a/drivers/net/ethernet/airoha/airoha_eth.h
>>> +++ b/drivers/net/ethernet/airoha/airoha_eth.h
>>> @@ -535,10 +535,15 @@ struct airoha_qdma {
>>> struct airoha_queue q_rx[AIROHA_NUM_RX_RING];
>>> };
>>>
>>> +struct airoha_gdm_dev {
>>> + struct airoha_gdm_port *port;
>>> + struct net_device *dev;
>>
>> Nit: we now have priv_to_netdev() (I hope I remember its name
>> correctly), so that we no longer need to store a netdev backpointer in
>> netdev_priv structures.
>> Just an option, up to you.
>
> I think you mean netdev_from_priv(), right?
Yep, priv_to_netdev() is something I used in the past locally, it went
to the kernel as netdev_from_priv() from a different author.
> I guess I can fix if I need to repost, otherwise I will fix with with a
> dedicated patch. Agree?
Sure, up to you anyway whether to use it. Most drivers still use
backpointers to netdev in their private structures.
From the optimization PoV, netdev_from_priv() should generate a bit
better code as it's then clear that it's just a fixed offset from the
private structure, not a separate piece of memory.
>
> Regards,
> Lorenzo
Thanks,
Olek
next prev parent reply other threads:[~2026-05-29 15:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 10:21 [PATCH net-next 0/6] net: airoha: Preliminary patches to support multiple net_devices connected to the same GDM port Lorenzo Bianconi
2026-05-27 10:21 ` [PATCH net-next 1/6] net: airoha: Introduce airoha_gdm_dev struct Lorenzo Bianconi
2026-05-28 12:38 ` Lorenzo Bianconi
2026-05-28 13:42 ` Alexander Lobakin
2026-05-28 16:09 ` Lorenzo Bianconi
2026-05-29 15:04 ` Alexander Lobakin [this message]
2026-05-29 16:43 ` Lorenzo Bianconi
2026-05-27 10:21 ` [PATCH net-next 2/6] net: airoha: Move airoha_qdma pointer in " Lorenzo Bianconi
2026-05-27 10:21 ` [PATCH net-next 3/6] net: airoha: Rely on airoha_gdm_dev pointer in airoha_is_lan_gdm_port() Lorenzo Bianconi
2026-05-27 10:21 ` [PATCH net-next 4/6] net: airoha: Move qos_sq_bmap in airoha_gdm_dev struct Lorenzo Bianconi
2026-05-28 12:49 ` Lorenzo Bianconi
2026-05-27 10:21 ` [PATCH net-next 5/6] net: airoha: Move {cpu,fwd}_tx_packets " Lorenzo Bianconi
2026-05-27 10:21 ` [PATCH net-next 6/6] net: airoha: Rename airoha_set_gdm2_loopback in airoha_enable_gdm2_loopback Lorenzo Bianconi
2026-06-02 20:30 ` [PATCH net-next 0/6] net: airoha: Preliminary patches to support multiple net_devices connected to the same GDM port patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=722f177c-0578-4b0b-b2fa-2acd45b2e299@intel.com \
--to=aleksander.lobakin@intel$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=xuegang.lu@airoha$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox