From: Florian Fainelli <f.fainelli@gmail•com>
To: Stefan Wahren <wahrenst@gmx•net>,
Matthias Brugger <matthias.bgg@kernel•org>,
Matthias Brugger <mbrugger@suse•com>,
"David S . Miller" <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>
Cc: Doug Berger <opendmb@gmail•com>,
netdev@vger•kernel.org, Eric Anholt <eric@anholt•net>,
bcm-kernel-feedback-list@broadcom•com,
Nicolas Saenz Julienne <nsaenzjulienne@suse•de>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH V3 net-next 6/7] net: bcmgenet: Add RGMII_RXID and RGMII_ID support
Date: Sun, 10 Nov 2019 12:32:38 -0800 [thread overview]
Message-ID: <741ffd9e-2f38-5605-2c44-e6411bf5d8d8@gmail.com> (raw)
In-Reply-To: <1573326009-2275-7-git-send-email-wahrenst@gmx.net>
On 11/9/2019 11:00 AM, Stefan Wahren wrote:
> This adds the missing support for the PHY modes RGMII_RXID and
> RGMII_ID. Based on the used register settings in the downstream tree
> the mode RGMII_RXID is necessary for the Raspberry Pi 4.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx•net>
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmmii.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index 8f7b2c0..9091e5b 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -273,6 +273,16 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
> phy_name = "external RGMII (TX delay)";
> port_ctrl = PORT_MODE_EXT_GPHY;
> break;
> +
> + case PHY_INTERFACE_MODE_RGMII_RXID:
> + phy_name = "external RGMII (RX delay)";
> + port_ctrl = PORT_MODE_EXT_GPHY;
> + break;
> +
> + case PHY_INTERFACE_MODE_RGMII_ID:
> + phy_name = "external RGMII (RX/TX delay)";
> + port_ctrl = PORT_MODE_EXT_GPHY;
> + break;
Technically for this one we should probably make sure that we do set
id_mode_dis in order for the MAC not to add the delay and leave the PHY
to do it though I don't have such a configuration handy to
prove/disprove that is necessary.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-10 20:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 19:00 [PATCH V3 net-next 0/7] ARM: Enable GENET support for RPi 4 Stefan Wahren
2019-11-09 19:00 ` [PATCH V3 net-next 1/7] net: bcmgenet: Avoid touching non-existent interrupt Stefan Wahren
2019-11-10 20:23 ` Florian Fainelli
2019-11-10 20:57 ` Stefan Wahren
2019-11-10 21:10 ` Florian Fainelli
2019-11-09 19:00 ` [PATCH V3 net-next 2/7] net: bcmgenet: Fix error handling on IRQ retrieval Stefan Wahren
2019-11-10 20:24 ` Florian Fainelli
2019-11-09 19:00 ` [PATCH V3 net-next 3/7] dt-bindings: net: bcmgenet: Add BCM2711 support Stefan Wahren
2019-11-10 20:23 ` Florian Fainelli
2019-11-09 19:00 ` [PATCH V3 net-next 4/7] " Stefan Wahren
2019-11-10 20:26 ` Florian Fainelli
2019-11-09 19:00 ` [PATCH V3 net-next 5/7] net: bcmgenet: Refactor register access in bcmgenet_mii_config Stefan Wahren
2019-11-10 20:34 ` Florian Fainelli
2019-11-09 19:00 ` [PATCH V3 net-next 6/7] net: bcmgenet: Add RGMII_RXID and RGMII_ID support Stefan Wahren
2019-11-10 20:32 ` Florian Fainelli [this message]
2019-11-09 19:00 ` [PATCH V3 net-next 7/7] ARM: dts: bcm2711-rpi-4: Enable GENET support Stefan Wahren
2019-11-10 20:26 ` [PATCH V3 net-next 0/7] ARM: Enable GENET support for RPi 4 Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741ffd9e-2f38-5605-2c44-e6411bf5d8d8@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric@anholt$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=matthias.bgg@kernel$(echo .)org \
--cc=mbrugger@suse$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nsaenzjulienne@suse$(echo .)de \
--cc=opendmb@gmail$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox