From: laurent.pinchart@ideasonboard•com (Laurent Pinchart)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM: shmobile: uImage load address rework
Date: Wed, 19 Jun 2013 15:16:01 +0200 [thread overview]
Message-ID: <76205076.EsFJngGrIh@avalon> (raw)
In-Reply-To: <3243557.sP7VV5jPVm@avalon>
Hi Magnus,
On Wednesday 12 June 2013 04:31:26 Laurent Pinchart wrote:
> On Wednesday 12 June 2013 11:21:34 Magnus Damm wrote:
> > On Wed, Jun 12, 2013 at 6:50 AM, Laurent Pinchart wrote:
> > > On Monday 10 June 2013 18:28:57 Magnus Damm wrote:
> > >> From: Magnus Damm <damm@opensource•se>
> > >>
> > >> This is V2 of the mach-shmobile uImage load address rework patch.
> > >>
> > >> Rework the mach-shmobile uImage load address calculation by storing
> > >> the per-board load addresses in Makefile.boot. This removes the
> > >> CONFIG_MEMORY_START dependency from Makefile.boot, and it also makes
> > >> it possible to create safe kernel images that boot on multiple boards.
> > >>
> > >> This is one of several series of code that reworks code not to rely on
> > >> CONFIG_MEMORY_START/SIZE which in turn is needed for
> > >> ARCH_MULTIPLATFORM.
> > >>
> > >> Signed-off-by: Magnus Damm <damm@opensource•se>
> > >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
> > >> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas•com>
> > >
> > > I've noticed today that KZM9G doesn't boot v3.10-rc2 with
> > > CONFIG_AUTO_ZRELADDR=y. While not caused by this patch, that's something
> > > that will need to be fixed to support multi-arch kernels. I'm not too
> > > familiar with early boot code, would you be able to have a look at this
> > > ?
> >
> > I will have a look. I suspect that issue is not related to this patch, is
> > it?
>
> No, it isn't, the issue is present in v3.10-rc2. I don't know if it has ever
> worked.
The following patch fixes the issue, caused by physical RAM being present at
0x41000000 on KZM9G. I'm not sure if it would be acceptable as a generic
solution though.
diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
index fe4d9c3..ea2f112 100644
--- a/arch/arm/boot/compressed/head.S
+++ b/arch/arm/boot/compressed/head.S
@@ -176,7 +176,7 @@ not_angel:
#ifdef CONFIG_AUTO_ZRELADDR
@ determine final kernel image address
mov r4, pc
- and r4, r4, #0xf8000000
+ and r4, r4, #0xff000000
add r4, r4, #TEXT_OFFSET
#else
ldr r4, =zreladdr
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-06-19 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 9:28 [PATCH v2] ARM: shmobile: uImage load address rework Magnus Damm
2013-06-11 7:47 ` Simon Horman
2013-06-11 9:33 ` Magnus Damm
2013-06-11 13:54 ` Guennadi Liakhovetski
2013-06-12 2:20 ` Magnus Damm
2013-06-12 6:22 ` Guennadi Liakhovetski
2013-06-11 21:50 ` Laurent Pinchart
2013-06-12 2:21 ` Magnus Damm
2013-06-12 2:31 ` Laurent Pinchart
2013-06-19 13:16 ` Laurent Pinchart [this message]
2013-06-25 14:00 ` Magnus Damm
2013-07-03 23:53 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76205076.EsFJngGrIh@avalon \
--to=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox