From: <Nicolas.Ferre@microchip•com>
To: <jonas@norrbonn•se>, <linux-kernel@vger•kernel.org>,
<broonie@kernel•org>
Cc: alexandre.belloni@bootlin•com, Tudor.Ambarus@microchip•com,
Ludovic.Desroches@microchip•com,
linux-arm-kernel@lists•infradead.org, linux-spi@vger•kernel.org
Subject: Re: [PATCH v5 2/2] spi-atmel: support inter-word delay
Date: Wed, 30 Jan 2019 08:15:56 +0000 [thread overview]
Message-ID: <78389342-af93-b233-e12e-5f6945bcb154@microchip.com> (raw)
In-Reply-To: <20190129205502.7741-3-jonas@norrbonn.se>
On 29/01/2019 at 21:55, Jonas Bonn wrote:
> If the SPI slave requires an inter-word delay, configure the DLYBCT
> register accordingly.
>
> Tested on a SAMA5D2 board (derived from SAMA5D2-Xplained reference
> board).
>
> Signed-off-by: Jonas Bonn <jonas@norrbonn•se>
> CC: Nicolas Ferre <nicolas.ferre@microchip•com>
> CC: Mark Brown <broonie@kernel•org>
> CC: Alexandre Belloni <alexandre.belloni@bootlin•com>
> CC: Ludovic Desroches <ludovic.desroches@microchip•com>
> CC: linux-spi@vger•kernel.org
> CC: linux-arm-kernel@lists•infradead.org
> ---
> drivers/spi/spi-atmel.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index f53f0c5e63da..57cc7110f9e8 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1201,13 +1201,14 @@ static int atmel_spi_setup(struct spi_device *spi)
> csr |= SPI_BIT(CSAAT);
>
> /* DLYBS is mostly irrelevant since we manage chipselect using GPIOs.
> - *
> - * DLYBCT would add delays between words, slowing down transfers.
> - * It could potentially be useful to cope with DMA bottlenecks, but
> - * in those cases it's probably best to just use a lower bitrate.
> */
> csr |= SPI_BF(DLYBS, 0);
> - csr |= SPI_BF(DLYBCT, 0);
> +
> + /* DLYBCT adds delays between words. This is useful for slow devices
> + * that need a bit of time to setup the next transfer.
> + */
> + csr |= SPI_BF(DLYBCT,
> + (as->spi_clk / 1000000 * spi->word_delay_us) >> 5);
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip•com>
> asd = spi->controller_state;
> if (!asd) {
>
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-30 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190129205502.7741-1-jonas@norrbonn.se>
2019-01-29 20:55 ` [PATCH v5 2/2] spi-atmel: support inter-word delay Jonas Bonn
2019-01-30 8:15 ` Nicolas.Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78389342-af93-b233-e12e-5f6945bcb154@microchip.com \
--to=nicolas.ferre@microchip$(echo .)com \
--cc=Ludovic.Desroches@microchip$(echo .)com \
--cc=Tudor.Ambarus@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=jonas@norrbonn$(echo .)se \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox