From: "Ardelean, Alexandru" <alexandru.Ardelean@analog•com>
To: "davem@davemloft•net" <davem@davemloft•net>
Cc: "alexandre.torgue@st•com" <alexandre.torgue@st•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"joabreu@synopsys•com" <joabreu@synopsys•com>,
"mcoquelin.stm32@gmail•com" <mcoquelin.stm32@gmail•com>,
"peppe.cavallaro@st•com" <peppe.cavallaro@st•com>,
"linux-stm32@st-md-mailman•stormreply.com"
<linux-stm32@st-md-mailman•stormreply.com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2] net: stmmac: socfpga: re-use the `interface` parameter from platform data
Date: Mon, 16 Sep 2019 06:58:44 +0000 [thread overview]
Message-ID: <7d2b366fb6969a2baed5639e3f8935fcce5e2f4b.camel@analog.com> (raw)
In-Reply-To: <20190915.195149.86866545205816280.davem@davemloft.net>
On Sun, 2019-09-15 at 19:51 +0100, David Miller wrote:
> [External]
>
> From: Alexandru Ardelean <alexandru.ardelean@analog•com>
> Date: Thu, 12 Sep 2019 16:28:50 +0300
>
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-
> > socfpga.c
> > index c141fe783e87..5b6213207c43 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> ...
> > +static inline int socfpga_get_plat_phymode(struct socfpga_dwmac *dwmac)
>
> Please do not use the inline keyword in foo.c files, let the compiler device.
Ack.
Will remove.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-16 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 13:28 [PATCH v2] net: stmmac: socfpga: re-use the `interface` parameter from platform data Alexandru Ardelean
2019-09-15 18:51 ` David Miller
2019-09-16 6:58 ` Ardelean, Alexandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d2b366fb6969a2baed5639e3f8935fcce5e2f4b.camel@analog.com \
--to=alexandru.ardelean@analog$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joabreu@synopsys$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox