From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] ARM64: dts: meson-axg: add saradc support
Date: Tue, 17 Jul 2018 10:28:11 -0500 [thread overview]
Message-ID: <7h4lgxop9w.fsf@baylibre.com> (raw)
In-Reply-To: <7h7elvmgnv.fsf@baylibre.com> (Kevin Hilman's message of "Mon, 16 Jul 2018 08:52:36 -0500")
Kevin Hilman <khilman@baylibre•com> writes:
> Jerome Brunet <jbrunet@baylibre•com> writes:
>
>> On Mon, 2018-07-02 at 22:25 +0000, Yixun Lan wrote:
>>> From: Xingyu Chen <xingyu.chen@amlogic•com>
>>>
>>> Add the DT info for SAR ADC of the Amlogic's Meson-AXG SoC.
>>>
>>> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic•com>
>>> Signed-off-by: Yixun Lan <yixun.lan@amlogic•com>
>>> ---
>>> Hi kevin
>>> I just re-send this patch which rebased to your khilman/v4.18/integ branch
>>> Thanks
>>> Yixun
>>>
>>> nothing changed since patch v1 [1]:
>>> -
>>>
>>> [1] https://lkml.kernel.org/r/20180326092117.208416-1-yixun.lan at amlogic.com
>>>
>>> ---
>>> .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 5 +++++
>>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 21 +++++++++++++++++++
>>> 2 files changed, 26 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>>> index 4b3331fbfe39..6041f68b32ae 100644
>>> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>>> @@ -153,3 +153,8 @@
>>> compatible = "brcm,bcm4329-fmac";
>>> };
>>> };
>>> +
>>> +&saradc {
>>> + status = "okay";
>>> + vref-supply = <&vddio_ao18>;
>>> +};
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>>> index 67d7115e4eff..52678a69dbf8 100644
>>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>>> @@ -91,6 +91,13 @@
>>> method = "smc";
>>> };
>>>
>>> + vddio_ao18: regulator-vddio_ao18 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "VDDIO_AO18";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + };
>>
>> Kevin, Yixun,
>>
>> I find odd that we are adding a regulator to SoC device tree file.
>> Those regulator are usually part of board file
>>
>> Unless the regulator is actually inside the SoC, this is not the place for it.
>>
>> Sorry for not catching this earlier.
>
> You're right, I should've noticed this earlier also.
>
> Yixun, can you resend this with the regulators in the board file please?
>
> In the mean time, I've dropped this from v4.19/dt64 branch,
Nevermind, Jerome fixed this up already in a series of DT updates for
AXG, so I'll keep it as is.
Thanks Jerome!
Kevin
prev parent reply other threads:[~2018-07-17 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:25 [PATCH v2] ARM64: dts: meson-axg: add saradc support Yixun Lan
2018-07-09 21:47 ` Kevin Hilman
2018-07-11 16:25 ` Jerome Brunet
2018-07-16 13:52 ` Kevin Hilman
2018-07-17 15:28 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4lgxop9w.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox