From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin
Date: Fri, 19 Aug 2016 15:23:19 -0700 [thread overview]
Message-ID: <7h4m6g7608.fsf@baylibre.com> (raw)
In-Reply-To: <20160819215547.20063-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Fri, 19 Aug 2016 23:55:42 +0200")
Martin Blumenstingl <martin.blumenstingl@googlemail•com> writes:
> This adds the IR remote receiver to the AO domain devices.
nit Re: Subject: should specify IR remote *input* pin.
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail•com>
> ---
> drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..8fffb31 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -225,6 +225,8 @@ static const unsigned int i2c_sda_ao_pins[] = {PIN(GPIOAO_5, 0) };
> static const unsigned int i2c_slave_sck_ao_pins[] = {PIN(GPIOAO_4, 0) };
> static const unsigned int i2c_slave_sda_ao_pins[] = {PIN(GPIOAO_5, 0) };
>
> +static const unsigned int ir_in_ao_pins[] = {PIN(GPIOAO_7, 0) };
> +
I'm trying to keep the names here so they match the datasheet, which
calls this remote_input_ao. Please update throughout the patch.
Otherwise looks good to me. Feel free to add
Reviewed-by: Kevin Hilman <khilman@baylibre•com>
and Linus W can queue it up.
Thanks,
Kevin
next prev parent reply other threads:[~2016-08-19 22:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160628191802.21227-1-martin.blumenstingl@googlemail.com>
2016-08-19 21:55 ` [PATCH v4 0/6] Add Meson 8b / GXBB support to the IR driver Martin Blumenstingl
2016-08-19 21:55 ` [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin Martin Blumenstingl
2016-08-19 22:23 ` Kevin Hilman [this message]
2016-08-19 21:55 ` [PATCH v4 2/6] ARM64: dts: amlogic: add the pin for the IR remote Martin Blumenstingl
2016-08-19 21:55 ` [PATCH v4 3/6] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-08-19 21:55 ` [PATCH v4 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-08-19 22:28 ` Kevin Hilman
2016-08-25 12:41 ` Mauro Carvalho Chehab
2016-08-19 21:55 ` [PATCH v4 5/6] ARM64: dts: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-08-19 21:55 ` [PATCH v4 6/6] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-08-20 9:54 ` [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver Martin Blumenstingl
2016-08-20 9:54 ` [PATCH v5 1/6] pinctrl: amlogic: gxbb: add the IR remote input pin Martin Blumenstingl
2016-08-22 13:51 ` Linus Walleij
2016-08-20 9:54 ` [PATCH v5 2/6] ARM64: dts: amlogic: add the input pin for the IR remote Martin Blumenstingl
2016-08-22 13:52 ` Linus Walleij
2016-08-20 9:54 ` [PATCH v5 3/6] dt-bindings: media: meson-ir: Add Meson8b and GXBB compatible strings Martin Blumenstingl
2016-08-20 9:54 ` [PATCH v5 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder Martin Blumenstingl
2016-08-20 9:54 ` [PATCH v5 5/6] ARM64: dts: meson-gxbb: Add Infrared Remote Controller decoder Martin Blumenstingl
2016-08-20 9:54 ` [PATCH v5 6/6] ARM64: dts: meson-gxbb: Enable the the IR decoder on supported boards Martin Blumenstingl
2016-08-29 19:28 ` [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver Kevin Hilman
2016-08-20 9:53 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4m6g7608.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox