From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/4] pinctrl: amlogic: Make driver independent from two-domain configuration
Date: Thu, 17 Mar 2016 08:35:33 -0700 [thread overview]
Message-ID: <7h7fh1t8vu.fsf@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2Ykgej4uyDLUvuSZyjiJwK1TF4RGYJQhXWubk69d1xA_Q@mail.gmail.com> (Carlo Caione's message of "Thu, 17 Mar 2016 08:09:28 +0100")
Carlo Caione <carlo@caione•org> writes:
> On Thu, Mar 17, 2016 at 4:31 AM, Kevin Hilman <khilman@baylibre•com> wrote:
>> Hi Carlo
>>
>> On Tue, Mar 1, 2016 at 2:04 PM, Carlo Caione <carlo@caione•org> wrote:
>>> From: Carlo Caione <carlo@endlessm•com>
>>>
>>> In the Amlogic Meson8 / Meson8b platforms we have two different buses:
>>> cbus and aobus, corresponding to 2 different power domains (regular and
>>> always-on). On each bus a different set of registers is mapped to manage
>>> muxes, GPIOs and in general to control a clear subset of the pins.
>>>
>>> Considering this architecture, having two different pinctrl devices, one
>>> for each bus / power domain, makes much more sense than just having one
>>> single device.
>>>
>>> Right now we have one single pin controller driver that uses two
>>> different domains (represented by 'gpio' and 'gpio-ao' sub-nodes in the
>>> DTS) to manage the set of registers on the two buses. This dual-domain
>>> configuration is hardcoded into the driver that strictly requires one
>>> domain for each bus in the same pin controller device.
>>>
>>> With this patch we refactor the driver to allow splitting the driver in
>>> two parts. This change is needed to have a proper description of the HW
>>> in the device-tree where we want to introduce aobus and cbus.
>>>
>>> Signed-off-by: Carlo Caione <carlo@endlessm•com>
>>
>> kernelci.org detected that the meson8b-odroidc1 started failing boot
>> test in mainline[1] and I bisected it down to this patch, which is in
>> mainline in he form of commit 9dab1868ec0d (pinctrl: amlogic: Make
>> driver independent from two-domain configuration.)
>>
>> I confirmed that reverting this patch on top of Linus' master branch
>> (commit 9256d5a308c9) gets the odroid-c1 booting again.
>
> Yes, this is expected. Thank you for pointing this out.
> The problem is that the driver changes ended up in mainline before I
> could pull the DTS changes (waiting for the Rob's ACK on
> documentation).
Do you have an ack now? or are you still waiting?
> What's the fastest way to land the DTS changes in mainline at this point?
When you've collected the acks, send a pull request through arm-soc so
we can get it in via our fixes branch.
Kevin
next prev parent reply other threads:[~2016-03-17 15:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 22:04 [PATCH 0/4] Refactor pinctrl driver for aobus / cbus Carlo Caione
2016-03-01 22:04 ` [PATCH 1/4] pinctrl: amlogic: Separate some pin functions for Meson8 / Meson8b Carlo Caione
2016-03-09 5:59 ` Linus Walleij
2016-03-01 22:04 ` [PATCH 2/4] pinctrl: amlogic: Make driver independent from two-domain configuration Carlo Caione
2016-03-09 6:01 ` Linus Walleij
2016-03-17 3:31 ` Kevin Hilman
2016-03-17 4:28 ` Kevin Hilman
2016-03-17 7:09 ` Carlo Caione
2016-03-17 15:35 ` Kevin Hilman [this message]
2016-03-17 18:15 ` Carlo Caione
2016-03-18 16:14 ` Kevin Hilman
2016-03-01 22:04 ` [PATCH 3/4] ARM: dts: amlogic: Split pinctrl device for Meson8 / Meson8b Carlo Caione
2016-03-18 17:36 ` Andreas Färber
2016-03-01 22:04 ` [PATCH 4/4] documentation: Fix pinctrl documentation " Carlo Caione
2016-03-05 4:26 ` Rob Herring
2016-03-07 9:01 ` Carlo Caione
2016-03-09 9:41 ` [PATCH v2 " Carlo Caione
2016-03-15 9:10 ` Linus Walleij
2016-03-15 9:20 ` Carlo Caione
2016-03-18 16:59 ` Kevin Hilman
2016-03-18 17:45 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h7fh1t8vu.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox