From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/5] power: domain: add pm_genpd_exit
Date: Tue, 08 Dec 2015 10:59:00 -0800 [thread overview]
Message-ID: <7h8u54lqbv.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5665599A.4060509@nvidia.com> (Jon Hunter's message of "Mon, 7 Dec 2015 10:04:10 +0000")
Jon Hunter <jonathanh@nvidia•com> writes:
> On 04/12/15 17:45, Eric Anholt wrote:
>> From: Alexander Aring <alex.aring@gmail•com>
>>
>> This patch adds function pm_genpd_exit for undo a pm_genpd_init. This
>> is useful for multiple power domains while probing. If the probing fails
>> after one pm_genpd_init was called we need to undo all previous
>> registrations of generic pm domains inside the gpd_list list.
>>
>> There is a check on IS_ERR_OR_NULL(genpd) which is useful to check again
>> registered power domains and not registered domains, the driver can use
>> this mechanism to have an array with registered and non-registered power
>> domains, where non-registered power domains are NULL.
>>
>> Cc: Rafael J. Wysocki <rjw@rjwysocki•net>
>> Cc: Kevin Hilman <khilman@kernel•org>
>> Cc: Ulf Hansson <ulf.hansson@linaro•org>
>> Cc: Pavel Machek <pavel@ucw•cz>
>> Cc: Len Brown <len.brown@intel•com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
>> Signed-off-by: Alexander Aring <alex.aring@gmail•com>
>> Signed-off-by: Eric Anholt <eric@anholt•net>
>> Acked-by: Ulf Hansson <ulf.hansson@linaro•org>
>> ---
>> drivers/base/power/domain.c | 22 ++++++++++++++++++++++
>> include/linux/pm_domain.h | 4 ++++
>> 2 files changed, 26 insertions(+)
>>
>> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
>> index 167418e..e7aca27 100644
>> --- a/drivers/base/power/domain.c
>> +++ b/drivers/base/power/domain.c
>> @@ -1509,6 +1509,28 @@ void pm_genpd_init(struct generic_pm_domain *genpd,
>> }
>> EXPORT_SYMBOL_GPL(pm_genpd_init);
>>
>> +/**
>> + * pm_genpd_exit - Uninitialize a generic I/O PM domain object.
>> + * @genpd: PM domain object to uninitialize.
>> + */
>> +void pm_genpd_exit(struct generic_pm_domain *genpd)
>> +{
>> + if (IS_ERR_OR_NULL(genpd))
>> + return;
>> +
>> + /* check if domain is still in registered inside the pm subsystem */
>> + WARN_ON_ONCE(!list_empty(&genpd->master_links) ||
>> + !list_empty(&genpd->slave_links) ||
>> + !list_empty(&genpd->dev_list));
>> +
>
> Why not return an error here? Seems bad to remove it, if it could still
> be referenced by other domains.
I had pointed this out as well in an earlier review.
> Also not sure if you need to lock around the above test and removing the
> domain.
>
>> + mutex_lock(&gpd_list_lock);
>> + list_del(&genpd->gpd_list_node);
>> + mutex_unlock(&gpd_list_lock);
>> +
>> + mutex_destroy(&genpd->lock);
>> +}
>> +EXPORT_SYMBOL_GPL(pm_genpd_exit);
>> +
>
> BTW, I had just submitted a similar patch here [0]. So I would also like
> to see such an API added.
Between the two of you, maybe come up with an agreed upon patch and
re-submit.
Kevin
> Cheers
> Jon
>
> [0] http://marc.info/?l=devicetree&m=144924138932726&w=2
next prev parent reply other threads:[~2015-12-08 18:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 17:45 [PATCH v2 0/5] Raspberry Pi power domains v2 Eric Anholt
2015-12-04 17:45 ` [PATCH v2 1/5] power: domain: add pm_genpd_exit Eric Anholt
2015-12-07 10:04 ` Jon Hunter
2015-12-08 18:59 ` Kevin Hilman [this message]
2015-12-09 10:47 ` Alexander Aring
2015-12-09 10:54 ` Russell King - ARM Linux
2015-12-14 9:49 ` Ulf Hansson
2015-12-04 17:45 ` [PATCH v2 2/5] ARM: bcm2835: Define two new packets from the latest firmware Eric Anholt
2015-12-04 17:45 ` [PATCH v2 3/5] ARM: bcm2835: add rpi power domain driver Eric Anholt
2015-12-07 23:35 ` Kevin Hilman
2015-12-08 1:04 ` Eric Anholt
2015-12-08 18:19 ` Kevin Hilman
2015-12-11 18:13 ` Stefan Wahren
2015-12-04 17:45 ` [PATCH v2 4/5] dt-bindings: add rpi power domain driver bindings Eric Anholt
2015-12-04 17:45 ` [PATCH v2 5/5] ARM: bcm2835: Add the Raspberry Pi power domain driver to the DT Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8u54lqbv.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox