From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other
Date: Thu, 30 Apr 2015 08:44:49 -0700 [thread overview]
Message-ID: <7h8ud9pqmm.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CAJKOXPc6Epy_L+djManggcaYLaOrQ_c2S0=_GgU=dikuY1UU0g@mail.gmail.com> (Krzysztof Kozlowski's message of "Thu, 30 Apr 2015 08:56:50 +0900")
Krzysztof Kozlowski <k.kozlowski@samsung•com> writes:
> 2015-04-30 2:31 GMT+09:00 Kevin Hilman <khilman@kernel•org>:
>> Krzysztof Kozlowski <k.kozlowski@samsung•com> writes:
>>
>>> After adding display power domain for Exynos5250 in commit
>>> 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") the
>>> display on Chromebook Snow and others stopped working after boot.
>>>
>>> The reason for this suggested Andrzej Hajda: the DP clock was disabled.
>>> This clock is required by Display Port and is enabled by bootloader.
>>> However when FIMD driver probing was deferred, the display power domain
>>> was turned off. This effectively reset the value of DP clock enable
>>> register.
>>>
>>> When exynos-dp is later probed, the clock is not enabled and display is
>>> not properly configured:
>>>
>>> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok
>>> exynos-dp 145b0000.dp-controller: unable to config video
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
>>> Reported-by: Javier Martinez Canillas <javier.martinez@collabora•co.uk>
>>> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250")
>>> Cc: <stable@vger•kernel.org>
>>>
>>> ---
>>>
>>> This should fix issue reported by Javier [1][2].
>>>
>>> Tested on Chromebook Snow (Exynos 5250). More testing would be great,
>>> especially on other Exynos 5xxx products.
>>
>> I hoped to try this on my exynos5 boards, but it doesn't seem to apply
>> to linux-next or to Linus' master branch.
>>
>> Are there some other dependencies here?
>
> It is already applied:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1c363c7cccf64128087002b0779986ad16aff6dc
Er, yup. That would explain it. ;)
Sorry for the noise,
Kevin
next prev parent reply other threads:[~2015-04-30 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 15:57 [RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other Krzysztof Kozlowski
2015-04-29 17:31 ` Kevin Hilman
2015-04-29 23:56 ` Krzysztof Kozlowski
2015-04-30 15:44 ` Kevin Hilman [this message]
2015-04-30 15:57 ` Olof Johansson
2015-04-30 16:40 ` Javier Martinez Canillas
2015-04-30 16:50 ` Olof Johansson
2015-05-01 9:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8ud9pqmm.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox