From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable failure due to domain being gated
Date: Mon, 15 Dec 2014 14:26:18 -0800 [thread overview]
Message-ID: <7h8ui8h7n9.fsf@deeprootsystems.com> (raw)
In-Reply-To: <7hlhmfo1b0.fsf@deeprootsystems.com> (Kevin Hilman's message of "Wed, 10 Dec 2014 09:35:31 -0800")
Kevin Hilman <khilman@kernel•org> writes:
> Sylwester Nawrocki <s.nawrocki@samsung•com> writes:
>
>> On 09/12/14 13:59, Krzysztof Kozlowski wrote:
>>> On pi?, 2014-12-05 at 15:15 +0100, Krzysztof Kozlowski wrote:
>>>> > Audio subsystem clocks are located in separate block. On Exynos 5420 if
>>>> > clock for this block (from main clock domain) 'mau_epll' is gated then
>>>> > any read or write to audss registers will block.
>>>> >
>>>> > This kind of boot hang was observed on Arndale Octa and Peach Pi/Pit
>>>> > after introducing runtime PM to pl330 DMA driver. After that commit the
>>>> > 'mau_epll' was gated, because the "amba" clock was disabled and there
>>>> > were no more users of mau_epll.
>>>> >
>>>> > The system hang on one of steps:
>>>> > 1. Disabling unused clocks from audss block.
>>>> > 2. During audss GPIO setup (just before probing i2s0 because
>>>> > samsung_pinmux_setup() tried to access memory from audss block which was
>>>> > gated.
>>>> >
>>>> > Add a workaround for this by enabling the 'mau_epll' clock in probe.
>>>> >
>>>> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung•com>
>>>> > ---
>>>> > drivers/clk/samsung/clk-exynos-audss.c | 29 ++++++++++++++++++++++++++++-
>>>> > 1 file changed, 28 insertions(+), 1 deletion(-)
>>>
>>> Sorry for pinging so quick but merge window is open and it looks like
>>> booting Exynos542x boards will be broken (because pl330 will no longer
>>> hold adma clock enabled so whole audss domain will be gated).
>>>
>>> This is a non-intrusive workaround for that issue, as wanted by
>>> Sylwester:
>>> https://lkml.org/lkml/2014/12/5/223
>>>
>>> Any comments on this?
>>
>> The patch looks OK to me, it would be good though if someone else
>> has confirmed it fixes the bug. I don't have any clock patches queued
>> at the moment. Perhaps you could apply it directly, Mike ?
>
> I confirm it fixes the boot hang in linux-next (next-20141210) on my
> exynos5800-peach-pi and exynos5420-arndale-octa. Tested both
> exynos_defconfig and multi_v7_defconfig.
>
> Tested-by: Kevin Hilman <khilman@linaro•org>
What's the status of this patch? linux-next is still broken for several
Exynos5 platforms without this fix.
Kevin
next prev parent reply other threads:[~2014-12-15 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 14:15 [PATCH] clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable failure due to domain being gated Krzysztof Kozlowski
2014-12-09 12:59 ` Krzysztof Kozlowski
2014-12-09 13:18 ` Sylwester Nawrocki
2014-12-09 14:05 ` Javier Martinez Canillas
2014-12-10 17:35 ` Kevin Hilman
2014-12-15 22:26 ` Kevin Hilman [this message]
2014-12-16 8:20 ` Krzysztof Kozlowski
2014-12-17 15:23 ` Mike Turquette
2014-12-18 6:58 ` Mike Turquette
2014-12-18 22:10 ` Kevin Hilman
2014-12-18 22:32 ` Mike Turquette
2014-12-24 16:36 ` Paolo Pisati
2015-01-02 9:49 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8ui8h7n9.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox