From: khilman@linaro•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 09/11] arm: add support for reserved memory defined by device tree
Date: Thu, 13 Mar 2014 14:51:56 -0700 [thread overview]
Message-ID: <7h8usdlqbn.fsf@paris.lan> (raw)
In-Reply-To: <20140313213636.GR18529@joshc.qualcomm.com> (Josh Cartwright's message of "Thu, 13 Mar 2014 16:36:36 -0500")
Josh Cartwright <joshc@codeaurora•org> writes:
> On Thu, Mar 13, 2014 at 01:46:50PM -0700, Kevin Hilman wrote:
>> On Fri, Feb 21, 2014 at 4:25 AM, Marek Szyprowski
>> <m.szyprowski@samsung•com> wrote:
>> > Enable reserved memory initialization from device tree.
>> >
>> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung•com>
>>
>> This patch has hit -next and several legacy (non-DT) boot failures
>> were detected and bisected down to this patch. A quick scan looks
>> like there needs to be some sanity checking whether a DT is even
>> present.
>
> Hmm. Yes, the code unconditionally calls of_flat_dt_scan(), which will
> gladly touch initial_boot_params, even though it may be uninitialized.
> The below patch should allow these boards to boot...
>
> However, I'm wondering if there is a good reason why we don't parse the
> /reserved-memory nodes at the right after we parse the /memory nodes as
> part of early_init_dt_scan()...
>
> Thanks,
> Josh
>
> --8<--
> Subject: [PATCH] drivers: of: only scan for reserved mem when fdt present
>
> Reported-by: Kevin Hilman <khilman@linaro•org>
> Signed-off-by: Josh Cartwright <joshc@codeaurora•org>
This gets legacy boot working again. Thanks.
Tested-by: Kevin Hilman <khilman@linaro•org>
Kevin
> ---
> drivers/of/fdt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 510c0d8..501bc83 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -557,6 +557,9 @@ static int __init __fdt_scan_reserved_mem(unsigned long node, const char *uname,
> */
> void __init early_init_fdt_scan_reserved_mem(void)
> {
> + if (!initial_boot_params)
> + return;
> +
> of_scan_flat_dt(__fdt_scan_reserved_mem, NULL);
> fdt_init_reserved_mem();
> }
next prev parent reply other threads:[~2014-03-13 21:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 12:25 [PATCH v5 00/11] reserved-memory regions/CMA in devicetree, again Marek Szyprowski
[not found] ` < 1392985527-6260-2-git-send-email-m.szyprowski@samsung.com>
[not found] ` < 1392985527-6260-7-git-send-email-m.szyprowski@samsung.com>
[not found] ` < 1392985527-6260-10-git-send-email-m.szyprowski@samsung.com>
[not found] ` < CAGa+x856+YyJ-vyfGoFAKmsqwKD+=Wh0-TT_mAaPStOXjd8eSQ@mail.gmail.com>
2014-02-21 12:25 ` [PATCH v5 01/11] of: document bindings for reserved-memory nodes Marek Szyprowski
2014-02-26 11:51 ` Grant Likely
2014-02-28 9:54 ` Marek Szyprowski
2014-02-28 10:01 ` Tomasz Figa
2014-03-01 19:58 ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 02/11] drivers: of: add initialization code for static reserved memory Marek Szyprowski
2014-02-26 12:05 ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 03/11] drivers: of: add initialization code for dynamic " Marek Szyprowski
2014-02-26 12:09 ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 04/11] drivers: of: add support for custom reserved memory drivers Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 05/11] drivers: of: add automated assignment of reserved regions to client devices Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 06/11] drivers: of: initialize and assign reserved memory to newly created devices Marek Szyprowski
2014-02-26 12:14 ` Grant Likely
2014-02-27 10:10 ` Marek Szyprowski
2014-03-01 20:20 ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 07/11] drivers: dma-coherent: add initialization from device tree Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 08/11] drivers: dma-contiguous: " Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 09/11] arm: add support for reserved memory defined by " Marek Szyprowski
2014-03-13 20:46 ` Kevin Hilman
2014-03-13 21:36 ` Josh Cartwright
2014-03-13 21:51 ` Kevin Hilman [this message]
2014-03-15 13:07 ` Grant Likely
2014-02-21 12:25 ` [PATCH v5 10/11] arm64: " Marek Szyprowski
2014-02-21 12:25 ` [PATCH v5 11/11] powerpc: " Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h8usdlqbn.fsf@paris.lan \
--to=khilman@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox