From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 0/2] Adds PMU and S2R support for exynos5420
Date: Thu, 09 Oct 2014 14:50:43 -0700 [thread overview]
Message-ID: <7hbnpknc98.fsf@deeprootsystems.com> (raw)
In-Reply-To: <CABxcv==V0vR2XXq5cKzbaqkCbtkqKgrhJotdPSM5K0uyNW968w@mail.gmail.com> (Javier Martinez Canillas's message of "Thu, 9 Oct 2014 11:48:28 +0200")
Javier Martinez Canillas <javier@dowhile0•org> writes:
> Hello Abhilash,
>
> On Thu, Oct 9, 2014 at 4:37 AM, Abhilash Kesavan
> <kesavan.abhilash@gmail•com> wrote:
>> Hi Kevin,
>>
>> On Thu, Oct 9, 2014 at 4:49 AM, Kevin Hilman <khilman@kernel•org> wrote:
>>> Vikas Sajjan <vikas.sajjan@samsung•com> writes:
>>>
>>> [...]
>>>
>>>> Tested on Kukjin Kim's tree, for-next branch +
>>>> 1] http://www.spinics.net/lists/linux-samsung-soc/msg33750.html
>>>> 2] https://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg37260.html
>>>> 3] with the CLK_IGNORE_UNUSED flag for aclk200_disp1 CLK
>>>>
>>>> on Exynos5420 based chromebook (peach-pit board)
>>>>
>>>> Below procedures were followed to test S2R:
>>>> Procedure A:
>>>> 1. make multi_v7_defconfig
>>>> 2 enable MCPM for 5420
>>>> 3. enable S3C RTC
>>>> 5. echo +20 > /sys/class/rtc/rtc0/wakealarm && echo mem > /sys/power/state
>>>> Procedure B:
>>>> 1. make exynos_defconfig
>>>> 4. echo +20 > /sys/class/rtc/rtc0/wakealarm && echo mem > /sys/power/state
>>>
>>> I went tried to this on exynos5800-peach-pi and found first that
>>> exynos_defonfig is missing the MAX77802 kconfig options for the RTC
>>> source clock:
>>>
>>> CONFIG_REGULATOR_MAX77802=y
>>> CONFIG_COMMON_CLK_MAX77802=y
>>
>> I am using exynos_defconfig (no changes) with the internal SoC RTC
>> which is enabled by default. I did not enable the MAX77802 RTC.
>
> That is because you probably are using kukjin's for-next branch as a
> base but I had the same issue when testing s2r on linux-next.
>
> The problem is that linux-next contains commit 546b117fdf17 ("rtc:
> s3c: add support for RTC of Exynos3250 SoC") that added a required
> "rtc_src" DT property for the Samsung's S3C RTC that is used to
> specify the source clock XrtcXTI.
>
> On Peach boards, the S3C source clock is the max77802 32kHZ AP clock
> so I fixed that with commit 8bd43b6 ("ARM: dts: Add rtc_src clk for
> s3c-rtc on exynos Peach boards") but didn't send a patch to enable the
> max77802 subdevices on exynos_defconfig.
>
> I'll post a patch to enable those config options today and maybe they
> can be considered as -rc material.
Great, thanks.
>>>
>>> With those, rtc0 then comes up, but isn't waking from suspend. However,
>>> writing something to rtc0/wakealarm does result in /proc/interrupts
>>> having an interrupt for the RTC, it's just not waking the system.
>>>
>>> Anyone else tried this on 5800/peach-pi?
>>
>> I have tested this on a Peach-Pi and the system is resuming fine. The
>> patches applied on kgene's for-next branch along with the
>> aclk200_disp1 fix are:
>> http://lkml.org/lkml/2014/9/30/156
>> https://lkml.org/lkml/2014/10/6/89
>> http://www.spinics.net/lists/arm-kernel/msg368207.html
>> http://www.spinics.net/lists/linux-samsung-soc/msg37647.html
>>
>
> Kevin, I didn't test it on 5800 peach pi but I did test it on 5420
> peach pit and as Abhilash said, I also needed Vikas patch [0] to flag
> the aclk200_disp1 and aclk300_disp1 clocks as CLK_IGNORE_UNUSED to
> prevent the ccf to disable them. With that patch Suspend-to-Ram worked
> for me and resuming using both the internal S3C RTC and the max77802
> RTC.
>
> Also I tested the pm_tests and all of them passed on my peach pit.
>
> On peach pi you shouldn't need the clock patch AFAIU if you enable the
> needed kconfig options to have display working since those clocks are
> used by the display controller so they won't be disabled due unused.
Thanks for the explanation.
Trying $SUBJECT series on top of kukjin's for-next is working fine, but
I'm still not able to make it work on linux-next, with or without the
CLK_IGNORE_UNUSED patch.
Abhilash, can you try this on exynos5800/peach-pi with linux-next and
see what else is missing from linux-next? It would be really nice to
get this fully working upstream.
Note also the enabling CPUidle depends on $SUBJECT series as well.
Kevin
next prev parent reply other threads:[~2014-10-09 21:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 9:22 [PATCH v9 0/2] Adds PMU and S2R support for exynos5420 Vikas Sajjan
2014-10-07 9:22 ` [PATCH v9 1/2] ARM: exynos5: Add PMU support for 5420 Vikas Sajjan
2014-10-07 12:32 ` Javier Martinez Canillas
2014-10-08 8:22 ` Vikas Sajjan
2014-10-07 9:22 ` [PATCH v9 2/2] ARM: exynos5: Add Suspend-to-RAM " Vikas Sajjan
2014-10-07 12:34 ` Javier Martinez Canillas
2014-10-08 8:23 ` Vikas Sajjan
2014-10-08 8:25 ` [PATCH v9 0/2] Adds PMU and S2R support for exynos5420 Vikas Sajjan
2014-10-08 8:37 ` Kukjin Kim
2014-10-08 9:26 ` Vikas Sajjan
2014-10-08 9:57 ` Javier Martinez Canillas
2014-10-08 11:51 ` Vikas Sajjan
2014-10-08 11:55 ` Javier Martinez Canillas
2014-10-08 23:19 ` Kevin Hilman
2014-10-09 2:37 ` Abhilash Kesavan
2014-10-09 9:48 ` Javier Martinez Canillas
2014-10-09 21:50 ` Kevin Hilman [this message]
2014-10-09 22:10 ` Javier Martinez Canillas
2014-10-09 22:59 ` Kevin Hilman
2014-10-10 3:25 ` Abhilash Kesavan
2014-10-10 22:02 ` Kevin Hilman
2014-10-11 4:04 ` Vikas Sajjan
2014-10-10 11:09 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hbnpknc98.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox