From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V5 11/14] soc: tegra: pmc: Add generic PM domain support
Date: Fri, 12 Feb 2016 15:14:04 -0800 [thread overview]
Message-ID: <7hh9hdzflv.fsf@baylibre.com> (raw)
In-Reply-To: <CAPDyKFpnUJA2pLSUOw8rkjyXLY6b__TM=38jsvYAZVhe+DS=zg@mail.gmail.com> (Ulf Hansson's message of "Thu, 4 Feb 2016 16:44:59 +0100")
Ulf Hansson <ulf.hansson@linaro•org> writes:
> On 28 January 2016 at 17:33, Jon Hunter <jonathanh@nvidia•com> wrote:
>> Adds generic PM support to the PMC driver where the PM domains are
>> populated from device-tree and the PM domain consumer devices are
>> bound to their relevant PM domains via device-tree as well.
>>
>> Update the tegra_powergate_sequence_power_up() API so that internally
>> it calls the same tegra_powergate_xxx functions that are used by the
>> tegra generic power domain code for consistency.
>>
>> This is based upon work by Thierry Reding <treding@nvidia•com>
>> and Vince Hsu <vinceh@nvidia•com>.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia•com>
[...]
>> +static void tegra_powergate_disable_clocks(struct tegra_powergate *pg)
>> +{
>> + unsigned int i;
>> +
>> + for (i = 0; i < pg->num_clks; i++)
>> + clk_disable_unprepare(pg->clks[i]);
>> +}
>> +
>> +static int tegra_powergate_enable_clocks(struct tegra_powergate *pg)
>> +{
>> + unsigned int i;
>> + int err;
>> +
>> + for (i = 0; i < pg->num_clks; i++) {
>> + err = clk_prepare_enable(pg->clks[i]);
>> + if (err)
>> + goto out;
>> + }
>> +
>> + return 0;
>> +
>> +out:
>> + while (i--)
>> + clk_disable_unprepare(pg->clks[i]);
>> +
>> + return err;
>> +}
>
> I have seen similar code around in other PM domains, dealing with
> enabling/disabling a *list* of clocks.
> Perhaps we should invent a new clock API that helps with this to
> prevents code duplication!?
What about the pm_clk_* API which was built for tracking clocks
associated with devices for runtime PM.
IOW, you could pm_clk_add(pg->pmc->dev, pg->clks[i]) and then your
_enable_clocks() would become pm_clk_suspend() an dyour
_disable_clocks() would become pm_clk_resume().
I might not be following the mapping between PMC and PGs though so not
sure pg->pmc->dev is the right struct device, but you get the idea.
Kevin
next prev parent reply other threads:[~2016-02-12 23:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 16:33 [PATCH V5 00/14] Add generic PM domain support for Tegra Jon Hunter
2016-01-28 16:33 ` [PATCH V5 01/14] soc: tegra: pmc: Restore base address on probe failure Jon Hunter
2016-01-28 16:33 ` [PATCH V5 02/14] soc: tegra: pmc: Protect public functions from potential race conditions Jon Hunter
2016-01-29 16:20 ` Mathieu Poirier
2016-02-01 13:42 ` Jon Hunter
2016-01-28 16:33 ` [PATCH V5 03/14] soc: tegra: pmc: Change powergate and rail IDs to be an unsigned type Jon Hunter
2016-01-28 16:33 ` [PATCH V5 04/14] soc: tegra: pmc: Fix testing of powergate state Jon Hunter
2016-01-28 16:33 ` [PATCH V5 05/14] soc: tegra: pmc: Wait for powergate state to change Jon Hunter
2016-01-29 16:58 ` Mathieu Poirier
2016-02-01 13:44 ` Jon Hunter
2016-02-03 9:20 ` Jon Hunter
2016-02-03 15:58 ` Mathieu Poirier
2016-01-28 16:33 ` [PATCH V5 06/14] soc: tegra: pmc: Fix checking of valid partitions Jon Hunter
2016-01-29 17:08 ` Mathieu Poirier
2016-02-01 13:45 ` Jon Hunter
2016-01-28 16:33 ` [PATCH V5 07/14] soc: tegra: pmc: Ensure partitions can be toggled on/off by PMC Jon Hunter
2016-01-28 16:33 ` [PATCH V5 08/14] PM / Domains: Add function to remove a pm-domain Jon Hunter
2016-02-02 15:35 ` Ulf Hansson
2016-02-03 10:51 ` Jon Hunter
2016-01-28 16:33 ` [PATCH V5 09/14] Documentation: DT: bindings: Update NVIDIA PMC for Tegra Jon Hunter
2016-01-29 16:08 ` Rob Herring
2016-01-28 16:33 ` [PATCH V5 10/14] Documentation: DT: bindings: Add power domain info for NVIDIA PMC Jon Hunter
2016-01-29 16:06 ` Rob Herring
2016-02-03 11:02 ` Jon Hunter
2016-02-03 15:48 ` Rob Herring
2016-02-10 10:57 ` Jon Hunter
2016-02-10 14:06 ` Rob Herring
2016-01-28 16:33 ` [PATCH V5 11/14] soc: tegra: pmc: Add generic PM domain support Jon Hunter
2016-02-04 15:44 ` Ulf Hansson
2016-02-10 18:01 ` Jon Hunter
2016-02-10 18:25 ` Ulf Hansson
2016-02-11 9:13 ` Jon Hunter
2016-02-11 9:57 ` Ulf Hansson
2016-02-11 10:13 ` Jon Hunter
2016-02-11 10:26 ` Jon Hunter
2016-02-11 10:37 ` Ulf Hansson
2016-02-11 10:52 ` Jon Hunter
2016-02-11 10:28 ` Ulf Hansson
2016-02-11 16:38 ` Jon Hunter
2016-02-18 15:06 ` Ulf Hansson
2016-02-12 23:14 ` Kevin Hilman [this message]
2016-02-15 11:27 ` Jon Hunter
2016-02-18 16:00 ` Ulf Hansson
2016-02-18 16:31 ` Jon Hunter
2016-02-24 0:03 ` Kevin Hilman
2016-01-28 16:33 ` [PATCH V5 12/14] clk: tegra210: Add the APB2APE audio clock Jon Hunter
2016-02-02 14:37 ` Thierry Reding
2016-01-28 16:33 ` [PATCH V5 13/14] ARM64: tegra: Add audio PM domain device node for Tegra210 Jon Hunter
2016-01-28 16:33 ` [PATCH V5 14/14] ARM64: tegra: select PM_GENERIC_DOMAINS Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hh9hdzflv.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox