From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3
Date: Wed, 01 Apr 2015 12:27:04 -0700 [thread overview]
Message-ID: <7hh9sz6453.fsf@deeprootsystems.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1504011130030.14762@ayla.of.borg> (Geert Uytterhoeven's message of "Wed, 1 Apr 2015 11:37:13 +0200 (CEST)")
Geert Uytterhoeven <geert@linux-m68k•org> writes:
[...]
>> build bisect points to commit 21f992084aeb[3], but that doesn't revert
>> cleanly so I haven't got any further than that yet.
>
> I installed gcc-arm-linux-gnueabi (4:4.7.2-1 from Ubuntu 14.04 LTS) and could
> reproduce the ICE. I came up with the workaround below.
Awesome, thanks!
> Does this work for you?
Yes, that patch works well and fixes the regression. Build results for
all the defconfigs here:
http://kernelci.org/build/khilman/kernel/v4.0-rc6-8294-g2ef3958cc27e/
and the remaining issues arent' realted to this ICE.
> From 7ebe83316eaf1952e55a76754ce7a5832e461b8c Mon Sep 17 00:00:00 2001
> From: Geert Uytterhoeven <geert+renesas@glider•be>
> Date: Wed, 1 Apr 2015 11:22:51 +0200
> Subject: [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in
> gcc 4.7.3
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> With gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-12ubuntu1) :
>
> mm/migrate.c: In function ?migrate_pages?:
> mm/migrate.c:1148:1: internal compiler error: in push_minipool_fix, at config/arm/arm.c:13500
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <file:///usr/share/doc/gcc-4.7/README.Bugs> for instructions.
> Preprocessed source stored into /tmp/ccPoM1tr.out file, please attach this to your bugreport.
> make[1]: *** [mm/migrate.o] Error 1
> make: *** [mm/migrate.o] Error 2
>
> Mark unmap_and_move() (which is used in a single place only) "noinline"
> to work around this compiler bug.
>
> Reported-by: Kevin Hilman <khilman@kernel•org>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider•be>
Tested-by: Kevin Hilman <khilman@linaro•org>
> ---
> mm/migrate.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 114602a68111d809..98f8574456c2010c 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -904,9 +904,10 @@ out:
> * Obtain the lock on page, remove all ptes and migrate the page
> * to the newly allocated page in newpage.
> */
> -static int unmap_and_move(new_page_t get_new_page, free_page_t put_new_page,
> - unsigned long private, struct page *page, int force,
> - enum migrate_mode mode)
> +static noinline int unmap_and_move(new_page_t get_new_page,
> + free_page_t put_new_page,
> + unsigned long private, struct page *page,
> + int force, enum migrate_mode mode)
> {
> int rc = 0;
> int *result = NULL;
next prev parent reply other threads:[~2015-04-01 19:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 0:45 Possible regression in next-20150323 due to "ARM, arm64: kvm: get rid of the bounce page" Simon Horman
2015-03-24 0:52 ` Tyler Baker
2015-03-24 0:53 ` Tyler Baker
2015-03-24 8:31 ` Ard Biesheuvel
2015-03-24 16:13 ` Nishanth Menon
2015-03-26 0:39 ` Simon Horman
2015-03-26 13:36 ` Will Deacon
2015-03-26 15:29 ` Tyler Baker
2015-03-27 0:25 ` Simon Horman
2015-03-27 10:06 ` Will Deacon
2015-03-27 11:55 ` Simon Horman
2015-03-27 15:18 ` Tyler Baker
2015-03-31 18:58 ` Kevin Hilman
2015-03-31 21:39 ` Ard Biesheuvel
2015-03-31 22:10 ` Kevin Hilman
2015-04-01 9:37 ` [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 (was: Re: Possible regression in gcc 4.7.3 next-20150323 due to "ARM, arm64: kvm: get rid of the bounce page") Geert Uytterhoeven
2015-04-01 9:47 ` [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 Marc Zyngier
2015-04-01 19:40 ` Andrew Morton
2015-04-01 21:54 ` Kevin Hilman
2015-04-01 21:59 ` Russell King - ARM Linux
2015-04-02 7:17 ` Geert Uytterhoeven
2015-04-02 19:12 ` Lina Iyer
2015-04-02 21:12 ` Kevin Hilman
2015-04-02 21:53 ` Lina Iyer
2015-04-07 17:57 ` Kevin Hilman
2015-04-07 20:17 ` Andrew Morton
2015-04-07 22:41 ` Kevin Hilman
2015-04-07 22:53 ` Andrew Morton
2015-04-07 23:27 ` Kevin Hilman
2015-04-07 23:36 ` Andrew Morton
2015-04-08 0:15 ` Kevin Hilman
2015-04-01 19:27 ` Kevin Hilman [this message]
2015-04-01 8:58 ` Possible regression in next-20150323 due to "ARM, arm64: kvm: get rid of the bounce page" Will Deacon
2015-04-01 13:54 ` Nishanth Menon
2015-04-01 18:12 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hh9sz6453.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox