From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 5/6] ARM64: meson-gxbb-p20x: Enable USB Nodes
Date: Thu, 15 Sep 2016 15:09:46 -0700 [thread overview]
Message-ID: <7hmvj8ke6t.fsf@baylibre.com> (raw)
In-Reply-To: <7h37l2mk6a.fsf@baylibre.com> (Kevin Hilman's message of "Wed, 14 Sep 2016 11:05:17 -0700")
Kevin Hilman <khilman@baylibre•com> writes:
> Martin Blumenstingl <martin.blumenstingl@googlemail•com> writes:
>
>> From: Jerome Brunet <jbrunet@baylibre•com>
>>
>> Enable both gxbb USB controller and add a 5V regulator for the OTG port
>> VBUS
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre•com>
>
> nit: subject should have "ARM64: dts:" prefix.
>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 29 ++++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
>> index ce105fe..4493bce 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi
>> @@ -93,6 +93,18 @@
>> compatible = "mmc-pwrseq-emmc";
>> reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;
>> };
>> +
>> + usb_vbus: regulator-usb0-vbus {
>
> nit: I like to use the signal name from the schematics for the node name
> (and for regulator-name below). In the schematics, that signal is named
> USB_PWR.
>
>
>> + compatible = "regulator-fixed";
>> +
>> + regulator-name = "USB0_VBUS";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> +
>> + gpio = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>;
>
> Please add a comment above this line with the schematic signal name: USB_PWR_EN.
>
For the record... after a chat with Martin on IRC, I just fixed these up
myself locally, so...
Applied,
Kevin
next prev parent reply other threads:[~2016-09-15 22:09 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 21:31 [PATCH 0/7] usb/phy: Add Amlogic Meson8b and GXBB USB support Martin Blumenstingl
2016-09-04 21:31 ` [PATCH 1/7] clk: gxbb: expose USB clocks Martin Blumenstingl
2016-09-07 0:33 ` Stephen Boyd
2016-09-07 21:32 ` Martin Blumenstingl
2016-09-07 22:14 ` Stephen Boyd
2016-09-08 2:24 ` Kevin Hilman
2016-09-07 21:28 ` Stephen Boyd
2016-09-08 19:24 ` Kevin Hilman
2016-09-04 21:31 ` [PATCH 2/7] usb: dwc2: add support for Meson8b and GXBB SoCs Martin Blumenstingl
2016-09-07 21:04 ` John Youn
2016-09-04 21:31 ` [PATCH 3/7] Documentation: dt-bindings: Add documentation for the Meson USB2 PHYs Martin Blumenstingl
2016-09-04 21:31 ` [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB Martin Blumenstingl
2016-09-08 19:35 ` Kevin Hilman
2016-09-08 19:40 ` Ben Dooks
2016-09-08 19:52 ` Martin Blumenstingl
2016-09-08 20:20 ` Ben Dooks
2016-09-08 20:42 ` Kevin Hilman
2016-09-08 20:53 ` Ben Dooks
2016-09-08 21:48 ` Martin Blumenstingl
2016-09-09 15:33 ` Kevin Hilman
2016-09-09 16:14 ` Martin Blumenstingl
2016-09-09 17:04 ` Kevin Hilman
2016-09-09 17:21 ` Ben Dooks
2016-09-09 20:37 ` Martin Blumenstingl
2016-09-16 8:19 ` Kishon Vijay Abraham I
2016-09-16 13:47 ` Arnd Bergmann
2016-09-18 19:56 ` Martin Blumenstingl
2016-09-19 4:59 ` Kishon Vijay Abraham I
2016-09-19 7:37 ` Arnd Bergmann
2016-09-09 20:36 ` Martin Blumenstingl
2016-09-11 13:44 ` Martin Blumenstingl
2016-09-12 17:32 ` Kevin Hilman
2016-09-13 15:28 ` Philipp Zabel
2016-09-13 18:38 ` Martin Blumenstingl
2016-09-14 0:59 ` Kevin Hilman
2016-09-14 8:36 ` Philipp Zabel
2016-09-14 8:37 ` Philipp Zabel
2016-09-14 21:09 ` Martin Blumenstingl
2016-09-14 8:37 ` Philipp Zabel
2016-09-14 21:23 ` Martin Blumenstingl
2016-09-15 10:30 ` Philipp Zabel
2016-09-04 21:31 ` [PATCH 5/7] ARM64: meson-gxbb: add USB Nodes Martin Blumenstingl
2016-09-05 0:23 ` Andreas Färber
2016-09-04 21:31 ` [PATCH 6/7] ARM64: meson-gxbb-p20x: Enable " Martin Blumenstingl
2016-09-04 21:31 ` [PATCH 7/7] ARM64: meson-gxbb-vega-s95: " Martin Blumenstingl
2016-09-11 13:41 ` [PATCH v2 0/6] usb/phy: Add Amlogic Meson8b and GXBB USB support Martin Blumenstingl
2016-09-11 13:41 ` [PATCH v2 1/6] usb: dwc2: add support for Meson8b and GXBB SoCs Martin Blumenstingl
2016-09-14 16:11 ` Kevin Hilman
2016-09-14 18:12 ` John Youn
2016-09-14 18:17 ` Kevin Hilman
2016-09-14 18:26 ` John Youn
2016-09-14 18:36 ` Kevin Hilman
2016-09-20 14:27 ` Rob Herring
2016-09-11 13:41 ` [PATCH v2 2/6] Documentation: dt-bindings: Add documentation for the Meson USB2 PHYs Martin Blumenstingl
2016-09-20 14:29 ` Rob Herring
2016-09-21 18:38 ` Kevin Hilman
2016-09-11 13:41 ` [PATCH v2 3/6] phy: meson: add USB2 PHY support for Meson8b and GXBB Martin Blumenstingl
2016-09-14 16:06 ` Kevin Hilman
2016-09-17 4:17 ` Kishon Vijay Abraham I
2016-09-19 16:42 ` Kevin Hilman
2016-09-20 5:01 ` Kishon Vijay Abraham I
2016-09-14 21:30 ` Martin Blumenstingl
2016-09-11 13:41 ` [PATCH v2 4/6] ARM64: meson-gxbb: add USB Nodes Martin Blumenstingl
2016-09-15 22:10 ` Kevin Hilman
2016-09-11 13:41 ` [PATCH v2 5/6] ARM64: meson-gxbb-p20x: Enable " Martin Blumenstingl
2016-09-14 18:05 ` Kevin Hilman
2016-09-15 22:09 ` Kevin Hilman [this message]
2016-09-11 13:41 ` [PATCH v2 6/6] ARM64: meson-gxbb-vega-s95: " Martin Blumenstingl
2016-09-15 22:10 ` Kevin Hilman
2016-10-01 12:18 ` [PATCH v3 0/3] usb/phy: Add Amlogic Meson8b and GXBB USB support Martin Blumenstingl
2016-10-01 12:18 ` [PATCH v3 1/3] Documentation: dt-bindings: update the meson-usb2-phy example Martin Blumenstingl
2016-10-09 1:28 ` Rob Herring
2016-10-01 12:18 ` [PATCH v3 2/3] Documentation: dt-bindings: rename meson-usb2-phy to meson8b-usb2-phy Martin Blumenstingl
2016-10-09 1:28 ` Rob Herring
2016-10-01 12:19 ` [PATCH v3 3/3] phy: meson: add USB2 PHY support for Meson8b and GXBB Martin Blumenstingl
2016-10-13 20:27 ` [PATCH v3 0/3] usb/phy: Add Amlogic Meson8b and GXBB USB support Martin Blumenstingl
2016-10-19 10:52 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hmvj8ke6t.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox