Subject: Re: [PATCH 2/2] soc: meson: enable building drivers as modules

From: Kevin Hilman <[email-masked]>
Date: Tue, 20 Oct 2020 14:00:30 -0700

Martin Blumenstingl <[email-masked]> writes:

> Hi Kevin,
>
> On Tue, Oct 20, 2020 at 12:47 AM Kevin Hilman <[email-masked]> wrote:
> [...]
>> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
>> index 5fb29a475879..2dfcb7b6e664 100644
>> --- a/drivers/soc/amlogic/meson-secure-pwrc.c
>> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
>> @@ -13,6 +13,7 @@
>>  #include <dt-bindings/power/meson-a1-power.h>
>>  #include <linux/arm-smccc.h>
>>  #include <linux/firmware/meson/meson_sm.h>
>> +#include <linux/module.h>
>>
>>  #define PWRC_ON                1
>>  #define PWRC_OFF       0
>> @@ -193,6 +194,7 @@ static const struct of_device_id meson_secure_pwrc_match_table[] = {
>>         },
>>         { /* sentinel */ }
>>  };
>> +MODULE_DEVICE_TABLE(of, meson_secure_pwrc_match_table);
>>
>>  static struct platform_driver meson_secure_pwrc_driver = {
>>         .probe = meson_secure_pwrc_probe,
>> @@ -201,4 +203,5 @@ static struct platform_driver meson_secure_pwrc_driver = {
>>                 .of_match_table = meson_secure_pwrc_match_table,
>>         },
>>  };
>> -builtin_platform_driver(meson_secure_pwrc_driver);
>> +module_platform_driver(meson_secure_pwrc_driver);
>> +MODULE_LICENSE("Dual BSD/GPL");
> This file uses SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> do we need to use MODULE_LICENSE("Dual MIT/GPL v2"); in this case?

Since the SPDX header says GPL2+, I'll change this to:
MODULE_LICENSE("Dual MIT/GPL");

Good catch, thanks!

Kevin

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel