From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] ARM: bcm2835: add rpi power domain driver
Date: Mon, 30 Nov 2015 15:51:56 -0800 [thread overview]
Message-ID: <7hr3j782qr.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1447956490-22930-3-git-send-email-alex.aring@gmail.com> (Alexander Aring's message of "Thu, 19 Nov 2015 19:08:09 +0100")
Alexander Aring <alex.aring@gmail•com> writes:
> This patch adds support for RPi several Power Domains and enable support
> to enable the USB Power Domain when it's not enabled before.
>
> This patch based on Eric Anholt's patch to support Power Domains. He had
> an issue about -EPROBE_DEFER inside the power domain subsystem, this
> issue was solved by commit <311fa6a> ("PM / Domains: Return -EPROBE_DEFER
> if we fail to init or turn-on domain").
[...]
> +#define RPI_POWER_DOMAIN(_domain, _name) \
> + [_domain] = { \
Using _domain as the array index is going to create a sparsely filled
array here, wasting memory. I'm not sure what the other domain numbers
are for other domains to know if this is a big waste or not, but it's
still a bit wasteful.
In any case, AFAICT, it doesn't look like you need to have the array
index match the domain number anyways since you're using container_of().
So I suggest just removing this array index part, and just creating them
in arrary order. Then your _probe function isn't going to try to setup
3 non-enabled domains before it finally hits the USB domain.
Kevin
next prev parent reply other threads:[~2015-11-30 23:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 18:08 [PATCH 0/3] ARM: bcm2835: add support for rpi power domain driver Alexander Aring
2015-11-19 18:08 ` [PATCH 1/3] power: domain: add pm_genpd_uninit Alexander Aring
2015-11-24 20:22 ` Ulf Hansson
2015-11-30 23:19 ` Kevin Hilman
2015-11-19 18:08 ` [PATCH 2/3] ARM: bcm2835: add rpi power domain driver Alexander Aring
2015-11-24 20:44 ` Ulf Hansson
2015-11-24 21:02 ` Alexander Aring
2015-11-25 19:33 ` Eric Anholt
2015-11-24 21:43 ` Eric Anholt
2015-11-30 23:51 ` Kevin Hilman [this message]
2015-12-01 21:00 ` Alexander Aring
2015-12-01 23:27 ` Kevin Hilman
2015-12-04 9:22 ` Alexander Aring
2015-11-19 18:08 ` [PATCH 3/3] devicetree: add rpi power domain driver bindings Alexander Aring
2015-11-20 16:14 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hr3j782qr.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox