From: khilman@kernel•org (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] tty: serial: msm_serial: Use DT aliases
Date: Tue, 11 Nov 2014 07:31:58 -0800 [thread overview]
Message-ID: <7hsihpois1.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5461150B.2010907@codeaurora.org> (Stephen Boyd's message of "Mon, 10 Nov 2014 11:42:03 -0800")
Stephen Boyd <sboyd@codeaurora•org> writes:
> On 11/10/2014 10:54 AM, Kevin Hilman wrote:
>> On Wed, Oct 22, 2014 at 5:33 PM, Stephen Boyd <sboyd@codeaurora•org> wrote:
>>> We rely on probe order of this driver to determine the line number for
>>> the uart port. This makes it impossible to know the line number
>>> when these devices are populated via DT. Use the DT alias
>>> mechanism to assign the line based on the aliases node.
>>>
>>> Signed-off-by: Stephen Boyd <sboyd@codeaurora•org>
>> FYI... this patch hit linux-next and caused multiple boot failures on
>> qcom platforms[1] as of next-20141110. I'm assuming this is because
>> the corresponding DTS changes have not hit linux-next yet.
>>
>> Kevin
>>
>> [1] http://status.armcloud.us/boot/?qcom
>
> Hmm the intention was to make it optional so that dts changes aren't
> necessary unless you want deterministic numbering. I screwed that up
> badly :/ Thanks for finding this.
>
> Greg, can you also apply this patch or squash it into the bad one?
>
> ----8<-----
>
> From: Stephen Boyd <sboyd@codeaurora•org>
> Subject: [PATCH] tty: serial: msm_serial: Don't required DT aliases
>
> If there isn't a DT alias then of_alias_get_id() will return
> -ENODEV. This will cause the msm_serial driver to fail probe,
> when we want to keep the previous behavior where we generated a
> dynamic line number at probe time. Restore this behavior by
> generating a dynamic id if the line number is still negative
> after checking for an alias or (in the non-DT case) looking at the
> .id field of the platform device.
>
> Reported-by: Kevin Hilman <khilman@kernel•org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora•org>
Tested-by: Kevin Hilman <khilman@linaro•org>
I confirm that this patch gets things booting again for the
msm8974/xperia-z1 and the apq8064/ifc6410.
Kevin
prev parent reply other threads:[~2014-11-11 15:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 0:33 [PATCH] tty: serial: msm_serial: Use DT aliases Stephen Boyd
2014-11-07 4:44 ` Frank Rowand
2014-11-10 23:53 ` Stephen Boyd
2014-11-11 2:20 ` Frank Rowand
2014-11-11 2:23 ` Stephen Boyd
2014-11-07 6:40 ` Frank Rowand
2014-11-07 6:42 ` Frank Rowand
2014-11-07 9:47 ` Arnd Bergmann
2014-11-07 21:35 ` Frank Rowand
2014-11-08 19:25 ` Arnd Bergmann
2014-11-10 18:54 ` Kevin Hilman
2014-11-10 19:42 ` Stephen Boyd
2014-11-11 1:56 ` Frank Rowand
2014-11-11 2:07 ` Stephen Boyd
2014-11-11 3:20 ` Frank Rowand
2014-11-12 18:14 ` Frank Rowand
2014-11-13 19:31 ` Stephen Boyd
2014-11-14 0:46 ` Frank Rowand
2014-11-14 0:59 ` Stephen Boyd
2014-11-14 17:43 ` Kevin Hilman
2014-11-14 18:33 ` Stephen Boyd
2014-11-11 15:31 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hsihpois1.fsf@deeprootsystems.com \
--to=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox